deduper's People
Forkers
deweesd lnassar alexadowdell gartician jasonsydes spencerseale eng3001 anniewly allyker joshsakai devarts5 severianovillarruel smvelazquez nwagner22 ntran95 abbieolson anastasiyaprymolenna paulaberry pranavs22 rylanci tcb72 jgallowa07 byoutsey mborche2 bencoziv gera912 ndeimler99 tucker-bower michal-babins bwinnacott kate-roth cameronfrwatson jonasgrove natalie-winans derrik-gratz megan-criss alyxgray7 susancollins chris-anthony m-chang3 demiglidden ryanjdecourcy nikkiszcdeduper's Issues
pseudocode feedback -MB
-Problem is well stated and concise. As the reader I can tell exactly what problem you are addressing. It might be helpful to include a quick statement of how your code will address the problem before you jump into it.
-General workflow gives a good overview of how your code will flow.
-For sort_SAM I'm pretty sure you can use a bash command that will sort your file
-Your get_UMI function is maybe a little too simplified to an outside reader. After reading through this and the main function I'm uncertain of it's prominent role and when you plan to call it. I would consider maybe explaining more, but I think in your actual code this will be a good function.
-get read info is well stated and defined. Good use of input and output.
-for the main_function, do you think keeping this a function or writing this as general code to help with memory storage will be better? I do think your structure and checks through the pseudocode are very logical and very easy to follow. It's easy to see how you are going to pass in your files, parse them, apply your duplicate checks, and then output to a "good or bad file". I feel like when you actually are writing your code you'll have a good structure to go off of. I think it would be helpful to add another little section after your functions to walk through how you plan to place and apply them.
I think you're on the right track though and your code is logically written and mostly easy to follow. If you have any questions or concerns with my statements feel free to reach out to me!
Peer Review - Nate Deimler
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.