luigifab / redmine-apijs

JavaScript pop-ups and slideshow for Redmine.

Stop russian war. 🇺🇦 Free Ukraine!

apijs

JavaScript pop-ups and slideshow for Redmine.

For more information, go to https://www.luigifab.fr/apijs and https://www.luigifab.fr/redmine/apijs (IPv6 is required) and https://www.redmine.org/plugins/apijs.

• Current version: 6.9.6 (01/01/2024)
• Compatibility: Redmine 1.4 / 2.x / 3.x / 4.x / 5.x, Python 3.3+
• Client compatibility: Firefox 36+, Chrome 32+, Opera 19+, Edge 16+, Safari 9+
• License: GNU GPL 2.0+

If you like, take some of your time to improve the translations, go to https://bit.ly/2HyCCEc.

redmine-apijs's Issues

[Feature request] PDF preview

Hello,
is it possible to extend the plugin by a PDF file preview?
I love the separation of the photo gallery and the files list. It would be cool, if the PDF files from the files list also open in a lightbox to preview and scroll to them.
Kind regards

Unable to download if content_type is null

Thank you & I love this plugin so much! I wonder if I can give my feedback here but I have no other way to go.
Redmine seems to set content_type to null when it's unable to determine the MIME type of the uploaded file. When users try to download this kind of file, they will encounter 500 internal error. The error looks like:

Sent file /redmine-4.1.1/files/2021/10/211014091631_test_file.lic (0.3ms)
Completed 500 Internal Server Error in 41ms (ActiveRecord: 29.5ms)

ArgumentError (:type option required):

I checked the code and find ApijsController is actually derived from Redmine's AttachmentsController, which make things easier.
I did a real quick workaround to avoid this error but wonder if it has any side effects. In ApijsController#download, Line 271:
replace type: @attachment.content_type with type: detect_content_type(@attachment)
The detect_content_type method from AttachmentsController will return 'application/octet-stream' if content_type is null.

Please let me know what you think, or I should use pull request, thank you.