malvinanikandrou / contvqa Goto Github PK

The way the type hinting is done for data structures, e.g. for dict, leads to RuntimeErrors in python 3.8.

[PEP 484 - Type Hints](PEP 484 – Type Hints) standardizes the way of doing type hints and says: "In addition to the above, the following special constructs defined below may be used: None, Any, Union, Tuple, Callable, all ABCs and stand-ins for concrete classes exported from typing (e.g. Sequence and Dict), type variables, and type aliases."

Therefore, it can be fixed by importing the right container from typing and using it, e.g. from typing import Dict and using Dict.

E.g. when running get_dataset_statistics.py

from contvqa.common import read_json, get_vqa_v2_mc_answers, get_vqa_v2_answer_sets
ModuleNotFoundError: No module named 'contvqa'

It can be fixed by importing directly: from common import read_json.

Or do you need importing like this for the packaging?