GithubHelp home page GithubHelp logo

Modularize code about pathostat HOT 4 OPEN

mani2012 avatar mani2012 commented on September 11, 2024 1
Modularize code

from pathostat.

Comments (4)

ecastron avatar ecastron commented on September 11, 2024

It makes sense to me. It'd be easier as we move forward and add more features. Going to give it a try with the longitudinal tab

from pathostat.

anfederico avatar anfederico commented on September 11, 2024

Here is a great barebones example of how one would modularize the code base.

https://github.com/daattali/advanced-shiny/tree/master/split-code

I think this project would benefit from this solution as the codebase is quite large. Some of the UI views are already modularized so maybe the best focus would be on making the server.R file modular (It's 2400 lines of code).

For example, each tab in the web-application would have a specific ui/server file.
ui_upload.R
server_upload.R
And so on for each tab...

Just a suggestion though, I know a big change like this takes considerable effort, but I would be willing to help! I'm sure it will benefit the project in terms of longevity.

from pathostat.

mlbendall avatar mlbendall commented on September 11, 2024

I already began to modularize the code, it just never made it into master. See the diversity module branch.

I'd suggest putting both the UI and server functions into the same file, and call the functions uploadModule and uploadModuleUI.

from pathostat.

anfederico avatar anfederico commented on September 11, 2024

Ah nice, looks good. What else needs to be done to merge? is the testing going smoothly?

Edit: I see, it's far behind the master.

from pathostat.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.