mapbox / shelf-pack-cpp Goto Github PK

Generate docs for this project rather than just pointing to the shelf-pack js docs.

I'm wondering why the parameters for Bin are set to default to -1, in particular for x and y. Would a better default be 0?

/cc @bhousel

JS shelf-pack is v2 now, so I should port those features to cpp also (refcounting and smarter waste management)

port mapbox/shelf-pack#10

duplicate symbol __ZN6mapboxlsERNSt3__113basic_ostreamIcNS0_11char_traitsIcEEEERKNS_3BinE in:
    /Users/john/Development/mapbox-gl-native/build/macos/mbgl.build/Debug/mbgl-test.build/Objects-normal/x86_64/bucket.test.o
    /Users/john/Development/mapbox-gl-native/build/macos/Debug/libmbgl-core.a(render_symbol_layer.o)

That demangles to mapbox::operator<<(std::__1::basic_ostream<char, std::__1::char_traits<char> >&, mapbox::Bin const&), which is defined without the inline keyword, so it ends up duplicated in any translation unit that includes shelf-pack.hpp.

Can we remove this function or move it to test.cpp so there's no <iostream> dependency in the header?

probably needs -std=c++14

port over the benchmarks from the shelf-pack js project