marmelroy / peekpop Goto Github PK

Awesome framework btw!

Peek shows viewController with UIScreen bounds instead of PeekPopView's bounds. So what I end up with is the clipping of the my actual viewController's view (and not the whole view itself).

Works well on a 6s though.

In GitHub repository description, "compatability" should be "compatibility".

@marmelroy How to use PeekPop swift file in Objective C project ?

I used swift library with bridging header in my objective c project but there seems to a problem with source view registration for 3D Touch.

When i converted this file i found this method under ForceTouchDelegate

• (void)registerFor3DTouch:(UIView * _Nonnull)sourceView viewController:(UIViewController * _Nonnull)viewController;

Now i do not know how to use this method to register source view for 3D Touch.

Instead of making a screenshot of a view controller at the begining and presenting a screenshot in the preview, you can present a viewController itself in the preview and make a screenshot of it at the commit. This screenshot is for smooth animation purpose only. The advantage is that if you have a content which is loaded from the server then it is loaded in the preview, just like in the original 3d Touch PeekPop. Below is the effect I was able to get.

It would be nice to see a list of apps using this PeekPop library.

There is a retain cycle that avoids to release the memory of the view controller using the PeekPop. The references to view controller and delegates inside the library should be weak.

@marmelroy

I updated using carthage update PeekPop and built the preview app. Still it results in a memory leak of +4MB per screenshot. Help??

When controller was popped, the collectionView cell object still retain by PeekPop.

It works only on first scroll frame, on invisible content not working.
Even after scroll, first frame freezes.

In sample app, if change column to 1 you can see the results.

Do you have any plan to adapt it for Swift 3?
This is really great project and I wish to use it

I know this cannot be implemented without the 3D touch API but could you add a gesture recognizer for when the peek method is run, and while the user still has is finger on the view and he swipes up, the action menu comes from below. Could you do that? Is that possible?

Currently producing blur screenshots takes about 0.20 second on iphone 5s, and this time is added every time the peekPopPossible method is invoked. Using UIVisualEffectView takes no time to generate, which makes the peekPop gesture much faster.

A plus is that all animations in the background are still visible (and blurred). The downside is that you cannot control blur radius, but this is only a visual downside.

Im using Kingfisher to download the images, and Im trying to show the a picture on peek mode, but it seams the view controller is going to be shown a screenshot is loaded or something, because the code gets to where it downloads, the callback is called when completed, but the actual Image is not shown

Any plans to move to Swift3?