Comments (7)
mattn
commented on July 24, 2024
@take-cheeze Would you mind that removing this part? https://github.com/mattn/mruby-onig-regexp/blob/master/src/mruby_onig_regexp.c#L124-L127
Any objection?
from mruby-onig-regexp.
take-cheeze
commented on July 24, 2024
@mattn I think it's unrelated to this issue.
It removes global variables "$#{last_match.length}" to "$9".
It's required to clear old match result.
I think mrb_gv_set failed because of other reason.
from mruby-onig-regexp.
take-cheeze
commented on July 24, 2024
Hmm, setting nil instead of removing should solve this.
Maybe mrb_gv_remove has some bug since there was khash changes to mruby recently.
from mruby-onig-regexp.
take-cheeze
commented on July 24, 2024
BTW mruby/mruby#2043 seems to fix this.
from mruby-onig-regexp.
matsumotory
commented on July 24, 2024
This issue was fixed by mruby/mruby#2043, and mrbgem_test_ci is passed. Thanks!
from mruby-onig-regexp.
ksss
commented on July 24, 2024
I'm sorry for my bug!
from mruby-onig-regexp.
take-cheeze
commented on July 24, 2024
@ksss No problem. Thanks for the fix!
from mruby-onig-regexp.
Related Issues (20)
- How to cross compile this gem? HOT 7
- Compilation failed on Visual Studio 2019
- Can not cross complie for x86_64-w64-mingw32 on Mac HOT 8
- test fails when MRB_UTF8_STRING is defined HOT 4
- No way to explicitly use the included libonig instead of what is installed on the host system
- ld: symbol(s) not found for architecture x86_64 HOT 3
- Slice on empty string
- gem description maybe is "鬼車", not "鬼雲" ? HOT 1
- string size too big (ArgumentError)
- infinite loop when empty regexp HOT 2
- Doesn't freak out when replacing `^` HOT 2
- Abort on UTF-8 split with empty src HOT 7
- /./ should match to latin-1 letter when MRB_UTF8_STRING is not defined.
- build with bundled onigmo fails when c++ API is enabled HOT 3
- Problems finding oniguruma.h HOT 2
- Support `Regexp#match?` HOT 8
- Freeze regex variable HOT 1
- Match? bug HOT 2
- Supporting non-word char in group name HOT 1
- slice! does not work with Regexp HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mruby-onig-regexp.