Segfault when creating offer with "audio: false" from CHROME about janus-gateway

[lminiero]

Thanks for the info: I was talking with another user of the fact that we hadn't tested the no-audio scenarios extensively, and your report confirms that there definitely is something that needs to be fixed there. The root cause of the issue is probably the bundling that happens in Chrome and not Firefox. By the way, have you checked with the latest version I committed a few minutes ago? There were changes to address bundling itself, and so something may have already been fixed in the process.

It's weird that audio:false fails, while recvAudio:false and sendAudio:false doesn't, though, as the former is a way to quick way to state the latter. I'll try and reproduce myself ASAP.

[lminiero]

Just FYI, the right syntax for sendonly/recvonly audio is not sendAudio/recvAudio, but audioSend/audioRecv. If you used the incorrect one, you were indeed not disabling audio in any direction at all, which explains why it worked.

[nschoe]

Ah ! This may explain why firefox still asks me for audio when I do that. I'll try that right now.
But the way I have tested with the version you uploaded a couple of days ago, not the last minute. I'll try the new syntax and I'll come back to you ASAP.

[nschoe]

Indeed : Firefox doesn't ask me for audio anymore, and you were right : when using audioSend: false and audioRecv: false I still have Janus segfaults with Chrome.

[nschoe]

(Sorry for multi post).
After severals tests, it seems this is the audioRecv: false which results in Janus' segfault, when used with Chrome.
Interestingly, audioRecv: true doesn't cause Janus to segfault.

I hope it helps you narrow down the code which causes that fault.

[lminiero]

Yep, I just replicated the issue locally. From a quick look it's definitely a mistake in handling the bundling im that case, so I'll start working on that right now. It's quite silly of me that I never tried that myself, though :-)

The audioRecv:false shouldn't be an issue per se, as we use sendonly streams in the Video MCU for publishers and it works fine there, but I'll have to check that as well.

[lminiero]

Just pushed a commit that should fix the issue (at least it does for me in the Echo Test). Let me know if it works for you as well, otherwise feel free to reopen the issue.

[nschoe]

It's okay now, no segfault anymore.
Nice, good work !