Using the DSP in a homebrew application crashes melonDS on linux about melonds

[AntonioND]

Using git bisect I've found the commit that introduced the error, but it's pretty big: bb42c8b

[RSDuck]

I cannot reproduce on Windows, I'll look at it on Linux (UBsan and asan) later.

[AntonioND]

Thanks. I've just tested it and it looks like it also happens with ROMs that don't use the DSP, so it is probably just related to the changes to the save data code.

[nadiaholmquist]

if you try to run that build of melonDS without giving it a ROM, does it also crash?

[AntonioND]

Yes, even without a ROM it crashes.

[nadiaholmquist]

Ah, you're probably hitting the issue that a lot of people are running into right now then. DSi mode will crash on launch unless ExternalBIOSEnable is set to 1 in the config and you have valid paths for all DS and DSi BIOS/firmware.

[AntonioND]

Ah, right, that seems to be the issue. Now it complains that my dumps aren't valid, for some reason (but I got them from my own console, so I'd hope they are valid?).

[nadiaholmquist]

It won't take the DS firmware dumped from a DSi in the DS mode settings (I swear that used to work?), maybe that's the problem.

[AntonioND]

Okay, I've just had to add every single BIOS/firmware file to the .ini file, including the DS mode BIOSes. Now it works!

[AntonioND]

I assume there is at least another issue keeping track of that bug, so feel free to close this issue, thanks for the help!