metamarcdw / nowallet Goto Github PK

Describe the bug
On spending, new unconfirmed 'Sent' transactions never appear in tx history.

To Reproduce
Steps to reproduce the behavior:

1. Run nowallet using any interface
2. Spend test coins
3. Wait for new tx to appear in history
4. See nothing happen

Expected behavior
A new entry should appear in the tx history as a spend.

Desktop (please complete the following information):

• OS: Ubuntu 18.04 bionic
• Interface: All
• Version: current tip of master branch c35f33a

Additional context
Python 3.6.5

Describe the bug
Attempting to spend TBTC from the send screen results in the UI freezing up.
[Theory]: Kivy doesn't seem to be playing well with asyncio, even with the async_gui lib.

To Reproduce
Steps to reproduce the behavior:

1. Go to the send screen
2. Enter a valid TBTC address and spend amount
3. Tap the "SEND TX" button
4. UI freezes up

Expected behavior
Should sign/broadcast TX, then show "Transaction sent!" message dialog with fee and TXID.

Desktop (please complete the following information):

• OS: Ubuntu 18.04 bionic
• Interface: Kivy UI
• Version: current tip of master branch 7431581

Additional context
Python 3.6.5

This a proposed fix for #5

To use async code (connectrum/nowallet lib) with Kivy, we have so far been using the approach described here:
https://github.com/kivy/kivy/wiki/Using-Asynchronous-programming-inside-a-Kivy-application

Would like to experiment with using the approach described here:
kivy/kivy#5241

We have to update to 3.7 (asyncio, cpython, ..) to make this going ...

Is your feature request related to a problem? Please describe.
Currently the buildozer spec file is not producing a functional APK, even on the Kivy Complete build VM.
https://github.com/Zen-CODE/kivybits/blob/master/KivyCompleteVM/ReadMe.txt

Describe the solution you'd like
Develop a working buildozer spec and start building Android releases.

See screenshot

Describe the bug
Attempting to lock the app with the PIN screen results in the UI freezing up.

To Reproduce
Steps to reproduce the behavior:

1. Go to the "Lock with PIN" screen
2. Enter any PIN number
3. Tap the "LOCK" button
4. UI freezes up

Expected behavior
"GO BACK" button should be greyed out to prevent returning to the app.
"LOCK" button text should change to "UNLOCK".
Input box for PIN number should clear.

Desktop (please complete the following information):

• OS: Ubuntu 18.04 bionic
• Interface: Kivy UI
• Version: current tip of master branch 7431581

Additional context
Python 3.6.5

Is your feature request related to a problem? Please describe.
It would be really nice to have a .deb build for use on TAILS and other Debian based systems.

Describe the solution you'd like
Develop a .deb packaging process and start building Debian releases.

We need more documentation about Nowallet; the pros and cons of brainwallets in general, and of Nowallet's approach specifically.

Hi @metamarcdw ,I am a graphic designer, I want to help others in graphic design.

After I review your project, your app is very good. But I think your icon is irrelevant to your application. Therefore I suggest a new logo and icon for you. If you want it, I will design it for you and it's free.

It seems that the core is working OK, but the UI has some serious problems.

"login" screen for key derivation

main menu when keys OK is missing (buttons), settings menu as well

Getting an error during key derivation. Occurring on Ubuntu using Python 3.5.2.

2017-12-12 20:38:40,276 INFO: Deriving keys...
Traceback (most recent call last):
  File "nowallet.py", line 1065, in <module>
    main()
  File "nowallet.py", line 1029, in main
    wallet = Wallet(email, passphrase, connection, loop, chain)  # type: Wallet
  File "nowallet.py", line 293, in __init__
    create_root_keys(salt, passphrase)
  File "nowallet.py", line 214, in inner
    func(*args, **kwargs)
  File "nowallet.py", line 270, in create_root_keys
    t = derive_key(salt, passphrase)  # type: Tuple[int, bytes]
  File "/home/user/nowallet/nowallet/keys.py", line 38, in derive_key
    digestmodule=hashlib.sha256).read(key_length)  # type: bytes
  File "/home/user/.local/lib/python3.5/site-packages/pbkdf2.py", line 161, in read
    block = self.__f(i)
  File "/home/user/.local/lib/python3.5/site-packages/pbkdf2.py", line 173, in __f
    U = self.__prf(self.__passphrase, self.__salt + pack("!L", i))
  File "/home/user/.local/lib/python3.5/site-packages/pbkdf2.py", line 146, in _pseudorandom
    digestmod=self.__digestmodule).digest()
  File "/usr/lib/python3/dist-packages/Crypto/Hash/HMAC.py", line 211, in new
    return HMAC(key, msg, digestmod)
  File "/usr/lib/python3/dist-packages/Crypto/Hash/HMAC.py", line 105, in __init__
    self.outer = digestmod.new()
AttributeError: 'builtin_function_or_method' object has no attribute 'new'

Got 2 TBTC and 0.5 TBTC.

See screenshots...

Is your feature request related to a problem? Please describe.
No.

Describe the solution you'd like
A redone UI.

Describe alternatives you've considered
I've retooled it and added dark mode.

Additional context
Here's the repo with the changed files: https://github.com/theREALaltoid/NWWEB-UI

https://github.com/metamarcdw/nowallet/blob/master/requirements.txt#L8
This is dangerous...

We should include the sources or better pin to version or commit.