Comments (4)
Wait, if it's empty something is wrong, it's ok to throw an error...
from hs2.
I agree, however it shouldn't crash the whole execution. How about a warning?
I am doing some automatic parameter optimisation, and sometimes I need to initialize parameters to something ridiculous (e.g. maxsl = 1 ). In that case I would like the program to handle this graciously.
from hs2.
I see what you mean. Do you actually need to load the detected spikes for that?
Incidentally, while you are at it, could you check if there are redundant parameters passed to the detection function? I don't even know what these parameters mean and it should be documented.
from hs2.
Yes, unfortunately I do need to load them. I've created a pull request with my code suggestion, what do you think?
I can check, no problem. Do you mean on python level, or cpp level?
from hs2.
Related Issues (20)
- `probe.py` path does not exist error when `RecordingExtractor` is called from SpikeToolkit
- Detection state is saving the wrong cutout_length
- Version in __version__ HOT 7
- clustering using DBSCAN HOT 1
- bug with HS 0.3.7 HOT 2
- Run `HS2` without probe file HOT 2
- version 0.3.99 fails at importing probe utils HOT 1
- Building wheel for herdingspikes (setup.py) ... error error: subprocess-exited-with-error HOT 3
- Version 0.3.100 fails at import HOT 3
- bug with the 0.3.7 version HOT 2
- Localization difference between BioCam and RecordingExtractor objects HOT 4
- create_probe_files leading to write OSError HOT 3
- Cant run herdingspikes HOT 3
- Trouble running HS on Spikeinterface HOT 5
- HS on Spike Interface HOT 1
- Kernel died when using herdingspikes in SpikeInterface HOT 2
- Build fails on Windows 10 HOT 3
- HerdingSpike through SpikeInterface wrongly scales waveform. HOT 1
- Issue using tutorial jupyter notebook (localised_spikes_clustered-biocam) HOT 2
- HS2 fails to build with Build Tools 2022 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hs2.