GithubHelp home page GithubHelp logo

Comments (4)

martinosorb avatar martinosorb commented on August 17, 2024

Wait, if it's empty something is wrong, it's ok to throw an error...

from hs2.

JanoHorvath avatar JanoHorvath commented on August 17, 2024

I agree, however it shouldn't crash the whole execution. How about a warning?

I am doing some automatic parameter optimisation, and sometimes I need to initialize parameters to something ridiculous (e.g. maxsl = 1 ). In that case I would like the program to handle this graciously.

from hs2.

martinosorb avatar martinosorb commented on August 17, 2024

I see what you mean. Do you actually need to load the detected spikes for that?

Incidentally, while you are at it, could you check if there are redundant parameters passed to the detection function? I don't even know what these parameters mean and it should be documented.

from hs2.

JanoHorvath avatar JanoHorvath commented on August 17, 2024

Yes, unfortunately I do need to load them. I've created a pull request with my code suggestion, what do you think?

I can check, no problem. Do you mean on python level, or cpp level?

from hs2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.