michaellass / aur Goto Github PK

After the installation of the packages aur/jabref not all files required for the integration with the browser extension are installed.
The file /opt/jabref/lib/jabrefHost.py (and the whole folder structure /opt/jabref/) is missing. Further the *.py files requires the executable to be spelled in lowercase (it is spelled JabRef but it should be jabref) for a flawless integration with the JabRef browser extension.

Related Issues:
JabRef/JabRef-Browser-Extension#158

A reminder to myself but of course open for suggestions:

• Move src.zip to a split src package
• Match naming of arch's openjdk builds for configuration folder:

  ls -d /etc/*jdk* 
  /etc/java-8-openjdk  /etc/java-openjdk  /etc/jdk11-adoptopenjdk  /etc/jdk-adoptopenjdk
  

Fritzing has some QT related issues with wayland. The wrong scaling makes it nearly unusable. The issue is quite easy to fix, by adding the launch parameter QT_AUTO_SCREEN_SCALE_FACTOR=0 . I've attached a patch file for the .desktop file, please add it to the PKGBUILD, this will fix the error.

Sorry for the .txt suffix, Github could not handle a .patch file.
fritzing.desktop.patch.txt

here is a patch to allow changing the default hotspot JVM
to the alternative openj9 JVM

edit: already exists as jdk14-openj9-bin

$ yay -Ss openj9-bin | grep ^aur | awk '{ print $1 }'
aur/jdk13-openj9-bin
aur/jdk14-openj9-bin
aur/jdk12-openj9-bin
aur/jdk10-openj9-bin
aur/jdk-openj9-bin
aur/jdk11-openj9-bin
aur/jdk9-openj9-bin
aur/jdk8-openj9-bin

see "help me choose" on https://adoptopenjdk.net/

in my case, the adopt compiler is two times slower
than the oracle compiler from java-jdk-14
but the runtime perf should be better

not sure if this is worth an extra AUR package

--- a/jdk-adoptopenjdk/PKGBUILD
+++ b/jdk-adoptopenjdk/PKGBUILD
@@ -14,8 +14,32 @@
 pkgver=${_completever}.u${_updatever}
 _tag_ver=${_completever}+${_updatever}
 
+#_jvm='hotspot'
+_jvm='openj9'
+# HotSpot is the VM from the OpenJDK community.
+#   It is the most widely used VM today and is used in Oracle’s JDK.
+#   It is suitable for all workloads.
+# Eclipse OpenJ9 is the VM from the Eclipse community.
+#   It is an enterprise-grade VM designed for low memory footprint and fast start-up
+#   and is used in IBM’s JDK. It is suitable for running all workloads.
+
+_tag_ver_jvm="${_tag_ver}"
+if [ "$_jvm" = 'openj9' ]; then
+  _tag_ver_jvm="${_tag_ver}_openj9-0.23.0"
+fi
+
 pkgname=jdk-adoptopenjdk
+if [ "$_jvm" = 'openj9' ]; then
+  pkgname="${pkgname}-openj9"
+fi
+
 pkgdesc="OpenJDK Java ${_majorver} development kit (AdoptOpenJDK build)"
+if [ "$_jvm" = 'openj9' ]; then
+  pkgdesc="${pkgdesc} (OpenJ9 JVM)"
+else
+  pkgdesc="${pkgdesc} (Hotspot JVM)"
+fi
+
 arch=('x86_64')
 url='https://adoptopenjdk.net/'
 license=('custom')
@@ -54,7 +78,7 @@
         etc/${pkgname}/sound.properties)
 install=install_jdk-adoptopenjdk.sh
 
-source=(https://github.com/AdoptOpenJDK/openjdk${_majorver}-binaries/releases/download/jdk-${_tag_ver/+/%2B}/OpenJDK${_majorver}U-jdk_x64_linux_hotspot_${_tag_ver/+/_}.tar.gz
+source=(https://github.com/AdoptOpenJDK/openjdk${_majorver}-binaries/releases/download/jdk-${_tag_ver_jvm/+/%2B}/OpenJDK${_majorver}U-jdk_x64_linux_${_jvm}_${_tag_ver_jvm/+/_}.tar.gz
         freedesktop-java.desktop
         freedesktop-jconsole.desktop
         freedesktop-jshell.desktop)
@@ -63,7 +87,16 @@
             'dafd84555287f16a59d4c7603167efc2a64a632780b6d8de109e75d6aa29782e'
             '4f05bf04f6397e9586881951116b3a12ae8336142e8be0caf196eaee1444c03f')
 
+if [ "$_jvm" = 'openj9' ]; then
+  # OpenJDK15U-jdk_x64_linux_openj9_15.0.1_9_openj9-0.23.0.tar.gz
+  sha256sums[0]='b1561f7a69c977bfc9991e61e96dcb200c39300dd9ad423254af117c189e4a8d'
+fi
+
 _jvmdir=/usr/lib/jvm/java-${_majorver}-adoptopenjdk
+if [ "$_jvm" = 'openj9' ]; then
+  _jvmdir="${_jvmdir}-openj9"
+fi
+
 _jdkdir=jdk-${_tag_ver}
 
 package() {

This is what I get when building (on armv7h):

[...]
Linking C static library libhts.a
[ 42%] Built target hts
Scanning dependencies of target pvr.hts
[ 50%] Building CXX object CMakeFiles/pvr.hts.dir/src/AsyncState.cpp.o
[ 57%] Building CXX object CMakeFiles/pvr.hts.dir/src/CircBuffer.cpp.o
[ 64%] Building CXX object CMakeFiles/pvr.hts.dir/src/client.cpp.o
/home/peter/kodi-addon-pvr-hts-git/src/kodi-addon-pvr-hts-git/src/client.cpp:24:33: fatal error: kodi/libKODI_guilib.h: No such file or directory
compilation terminated.
CMakeFiles/pvr.hts.dir/build.make:100: recipe for target 'CMakeFiles/pvr.hts.dir/src/client.cpp.o' failed
make[2]: *** [CMakeFiles/pvr.hts.dir/src/client.cpp.o] Error 1
CMakeFiles/Makefile2:91: recipe for target 'CMakeFiles/pvr.hts.dir/all' failed
make[1]: *** [CMakeFiles/pvr.hts.dir/all] Error 2
Makefile:136: recipe for target 'all' failed
make: *** [all] Error 2
==> ERROR: A failure occurred in build().
    Aborting...

CC=clang CXX=clang++ on my device.
llvm70 built without a hitch.
clang70 though through unrecognized file errors, lto errors, etc. even after resolving what I could; had various other problems.

workaround for now? added clang to the makedepends and added these to Cmake options:

-DCMAKE_C_COMPILER=/usr/bin/clang
-DCMAKE_CXX_COMPILER=/usr/bin/clang++ \

Has now built fine! Whoo hoo!

(Now I can build beignet-git with clang70/llvm70)

Thanks for maintaining these!

Having jdk-openjdk – which is at a 19 release, currently – installed leads to the build failing with the following error:

Using JDK from /usr/lib/jvm/java-19-openjdk to build JabRef.

Welcome to Gradle 7.5.1!

Here are the highlights of this release:
 - Support for Java 18
 - Support for building with Groovy 4
 - Much more responsive continuous builds
 - Improved diagnostics for dependency resolution

For more details see https://docs.gradle.org/7.5.1/release-notes.html

To honour the JVM settings for this build a single-use Daemon process will be forked. See https://docs.gradle.org/7.5.1/userguide/gradle_daemon.html#sec:disabling_the_daemon.
Daemon will be stopped at the end of the build 

FAILURE: Build failed with an exception.

* What went wrong:
Could not open cp_settings generic class cache for settings file '/home/lennart/.cache/yay/jabref/src/jabref-5.7/settings.gradle' (/home/lennart/.cache/yay/jabref/src/gradle/caches/7.5.1/scripts/d04h3m63n6pq1pc0mrj70hxnc).
> BUG! exception in phase 'semantic analysis' in source unit '_BuildScript_' Unsupported class file major version 63

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 2s
==> ERROR: A failure occurred in build().
    Aborting...
 -> error making: jabref

As far as my understanding goes, this is due to Java 19 not being supported by the Gradle version. The Jabref documentation https://devdocs.jabref.org/getting-into-the-code/guidelines-for-setting-up-a-local-workspace#java-development-kit-18 version 18 which is currently not packaged in the official repos.

So I can't figure out a way to build Jabref atm.

It's been quite some time since AdoptOpenJDK become Adoptium's Temurin officially. Do we have any plan for migration?

Lots of package managers already applied this. (Homebrew, Scoop, Chocolatey)

From https://aur.archlinux.org/packages/jabref#comment-892140

I am having trouble building in a clean chroot with makechrootpkg.

==> Starting build()... Your Java installation is not set up correctly. Try archlinux-java fix. Using JDK from to build JabRef.

ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH.

Please set the JAVA_HOME variable in your environment to match the location of your Java installation.

==> ERROR: A failure occurred in build(). Aborting...

I am installing jdk18-openj9-bin and archlinux-java-run from the AUR.

resolving dependencies... looking for conflicting packages...
Packages (6) java-environment-common-3-3 java-runtime-common-3-3 nspr-4.35-1 nss-3.85-1 archlinux-java-run-9-1 jdk18-openj9-bin-18.0.2.1-1

I think the recommendation to run "archlinux-java fix" is correct since if I manually enter the chroot and then run the "archlinux-java-run" command from the PKGBUILD, it does not return anything but if I run "archlinux-java fix", then the PKGBUILD command gives the correct version.

The issue, I think is that I cannot simply add "archlinux-java fix" to the build function in the PKGBUILD since the archlinux-java script requires root privileges and makechrootpkg drops privileges (I think).

JDK 11 is LTS and suppose to be supported by 2023 with patches.

Since 3.16, yed requires jre8:
https://www.yworks.com/products/yed/download#ReleaseNotes

Please, default it to jre8 and also add version dependency.