michalfoksa / rsmb Goto Github PK

Hello everyone,
I am using RSMB broker on Ubuntu 14.4 to send UDP packets. I have done bridging in between Mosquitto broker and RSMB broker. When I am sending any UDP packet to RSMB server/broker on specified MQTT-S port, I am facing an error:

20170721 125228.265 CWNAN0075W Socket error 107 (Transport endpoint is not connected) in getpeername for socket 4
20170721 125228.265 CWNAN0021W Badly formed packet on socket 4, peer address unknown; ending connection

If anyone finds a solution to fix this error, please help me to solve this.

I have found a issue with pre-defined topic IDs. The {clientid} was not being replaced with the topic name. It is a very small fix. How can I submit my change? (I'm new to github)

Thanks,
Jeff

If a client on a noisy network misses a SUBACK packet, it will resend the SUBSCRIBE. Since MQTTSProtocol_handleSubscribes doesn't check if a topic is already registered before registering it, it will send the next SUBACK with a new topic id. But later PUBLISHes on that topic will use the first topic id, which the client doesn't know.

The fix is to use the same check in MQTTProtocol_handleSubscribes that MQTTProtocol_handleRegisters uses to see if a topic is already registered.

Length of CRTL field in forwarder encapsulation packet is 1 octet and not 2.

Fix in:

MQTTSPacket.c -> MQTTSPacket_Factory
MQTTSPacketSerialize.c -> MQTTSPacketSerialize_forwarder_encapsulation

Here are the changes I had to make to build rsmb on OS X 10.11.5 running version 7.1.3 of the command line tools, for whoever might find them helpful:

In the makefile, change:
CFLAGS=-Wall
to
CFLAGS=-Wall -D_XOPEN_SOURCE

and in Socket.c on the one line where it occurs, change IPV6_ADD_MEMBERSHIP to IPV6_JOIN_GROUP

Hi Michal,

I am using your fork of this project to do some testing with mqttsn, and I noticed that the broker does not call MQTTProtocol_retries() for the mqtts clients, like it does for the mqtt clients.

Since you seem to care about this code base I thought I would share this with you. I dont know if this patch is even the bast way to implement the fix, but it seems like it should be ok.

Jeffrey

diff --git a/rsmb/src/MQTTSProtocol.c b/rsmb/src/MQTTSProtocol.c
index 049dc68..f88f991 100644
--- a/rsmb/src/MQTTSProtocol.c
+++ b/rsmb/src/MQTTSProtocol.c
@@ -551,7 +551,22 @@ int MQTTSProtocol_handleConnects(void* pack, int sock, char* clientAddr, Clients
}

    if (existingClient)

•   {
  

•           ListElement\* outcurrent = NULL;
  

•           time_t now = 0;
  

•           /\* ensure that inflight messages are retried now by setting the last touched time
  

•            \* to very old (0) before calling the retry function
  

•            */
  

•           time(&(now));
  

•           while (ListNextElement(client->outboundMsgs, &outcurrent))
  

•           {
  

•                   Messages\* m = (Messages*)(outcurrent->content);
  

•                   m->lastTouch = 0;
  

•           }
  

•           MQTTProtocol_retries(now, client);
          MQTTProtocol_processQueued(client);
  

•   }
  
  Log(LOG_INFO, 0, "Client connected to udp port %d from %s (%s)", list->port, client->clientID, clientAddr);
  

Any subscription to any topic always returns Topic ID: 0x0001.