GithubHelp home page GithubHelp logo

Comments (6)

turbomam avatar turbomam commented on June 21, 2024

OK. The permissible values for the enumeration should be very succinct, preferably a single word or something_snake_cased.

Class PermissibleValue takes most of the annotations as other LinkML meta classes

If we can find OBO foundry terms for those concepts, we should assign the term CURIEs to the meaning slot.

from nmdc-schema.

mslarae13 avatar mslarae13 commented on June 21, 2024

Low priority. Mark can add this enum. Will need review.
If not completed next sprint will not be included in berk roll out.

from nmdc-schema.

turbomam avatar turbomam commented on June 21, 2024

@aclum I just rewrote your title like a cowboy, but then thought oops maybe I don't really know what you want.

Can we just add permissible values to the existing LibraryTypeEnum, or do you really feel like a new slot is required? I see that you are suggesting a new slot called rna_seq_type. Does that mean that you would want to have something like this?

id: nmdc:libprp-99-abc123
type: nmdc:LibraryPreparation
library_type: RNA 
rna_seq_type: stranded_rnaseq_r1f_r2r

There aren't any library_type values other than 'DNA' in the metadata I put into GraphDB a week or two ago, so eliminating the 'RNA' value wouldn't require a migration.

Is there any circumstance you would want to say that the library_type is 'RNA' without asserting a rna_seq_type?

from nmdc-schema.

aclum avatar aclum commented on June 21, 2024

I would prefer this as a separate slot since we may not have this information or we'll have to infer it from a combination of institution+processing date.

from nmdc-schema.

aclum avatar aclum commented on June 21, 2024

@turbomam do you have time work on this ticket this sprint? @kaijli and I are reviewing the workflow and will need this information as a workflow parameter for the counting step. We'll need to reprocess existing projects after re-iding b/c the new workflow uses a different assembler.

from nmdc-schema.

mslarae13 avatar mslarae13 commented on June 21, 2024

re-iding needs to re-process metaT data. File type enum for metaT isn't sorted out.
Adding support for metaT allowed in soft freeze.
TBD, specific to 1 data type, so impacts shouldn't be huge.

from nmdc-schema.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.