Comments (2)
I don't know that Git allows for this: store files in the repo, but ignore changes to those files. 🤷
Maybe this will involve a check performed by GitHub Actions.
Or a $ make committable
command that uses Git to revert the generated files to their original states.
Maybe it will involve changing how/where the files are generated.
from nmdc-schema.
Thanks for thinking this though, @eecavanna
Here are my goals:
- all of the
project/
,nmdc_schema/
andexamples/output
files generated bymake squeaky-clean all test
should be included in releases. I think @pkalita-lbl thinks includingexamples/output/
and maybe some other generated files is excessive and I would be willing to reconsider. Theexamples/output/
files are nice because they show thesrc/data/valid/
files in their canonical forms. My release strategy has been- merging pending PRs into
main
- making and merging a new PR in which the version strings in
src/schema/nmdc.yaml
andpyproject.toml
are updated - checking out the latest
main
, runningmake squeaky-clean all test
, and committing that directly intomain
. That could be modified if there is a better flow.
- merging pending PRs into
- generally speaking, PRs should not update any of those files, with one big exception: Python code in
nmdc_schema/
authored by an NMDC team member. This is in contrast with autogenerated Python files in that directory, like the following. I am open to re-organizing the authored code from the generated code, but that shoud to be done in a way that doesn't complicate building or using the package.nmdc.py
nmdc_schema_accepting_legacy_ids.py
nmdc_schema_merged.yaml
- it would be nice if changes to
project/
, authored code innmdc_schema/
andexamples/output
was not reported bygit status
and was blocked by the.gitignore
, but if that isn't possible, we can write better documentation and/or restructurenmdc_schema/
- if merging the
berkeley-schema-fy24
fork intonmdc-schema
will cause conflicts inproject/
,nmdc_schema/
orexamples/output
, we could make an exception an allow that, following the release flow I have documented above
PS: when @aclum's Napa re-iding squad is done, we can modify the Makefiles so that the nmdc_schema_accepting_legacy_ids*
files aren't generated any more.
from nmdc-schema.
Related Issues (20)
- remove usages of class-sparql in project.Makefile HOT 1
- remove build-datafile-from-api-requests usages and *filtered-request* from project.Makefile
- remove fuseki container shutdown and direct TDB2 writing from project.Makefile
- remove mixs regernation by introspetion
- remove legacy files from `assets/`
- move all Neon mapping files to a single path
- for visualizations, `slot_usages` over object properties should indicate narrowest range
- what to exclude from visualizastion?
- what predicates should be asserted in visualizations, esp for MIxS slots
- has unit appears as a slot for Biosample HOT 4
- has_unit does not appear as a slot for QuantityValue in the online documentation ? HOT 1
- Split up MetatranscriptomeActivity like metaG was HOT 2
- `napa_compliance` branch: Make `insert_many_pymongo.py` more robust HOT 1
- Deprecate MetagenomeSequencingActivity
- `nmdc.owl` is being generated with URIs like `<https://w3id.org/mixs/depth>` not `<https://w3id.org/mixs/0000018>` HOT 3
- Update Code of conduct with staff feedback
- Update `extract_study` command to search Legacy IDs
- workarround: generate RDF joining element labels to id-based IRIs
- Check referential integrity of Napa squad's MongoDB database via SPARQL in Fuseki
- Add `associated_studies` onto Biosample and make part_of not required for Biosample
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nmdc-schema.