GithubHelp home page GithubHelp logo

Comments (6)

eecavanna avatar eecavanna commented on July 19, 2024 1

For the exceptions framework (decision framework), I propose this rule:

  1. If the PR consists of changes to the nmdc_schema/migrators directory only, then it can be merged in after the typical developer-level review/approval (i.e. without a squad-level discussion/approval).

I expect that situation to arise multiple times during the soft schema freeze.

from nmdc-schema.

turbomam avatar turbomam commented on July 19, 2024

see also

from nmdc-schema.

aclum avatar aclum commented on July 19, 2024

exception framework proposal:

  1. addition of python scripts to nmdc_schema
  2. New permissible values for enumerations (ie FileTypeEnum)
  3. changes to description/comment slots
  4. schema bug fixes identified during migration and testing on existing features

from nmdc-schema.

mslarae13 avatar mslarae13 commented on July 19, 2024

We can put the decision in the decision log? There's a note and decision logged in the metadata meeting note

  • Schema changes that have any downstream effects will not be permitted after May 31st(June 14th). Downstream relates to requirements for runtime, workflows, products, or any other components of NMDC
  • Changes to the schema that do not have downstream effects, are simply modeling changes that can be later implemented can be done on a branch and merged in AFTER review and evaluation.
    • Schema changes that don’t have downstream effects

Decision: Berkeley schema & nmdc-main schema changes should be reviewed and discussed with the team because nmdc-main schema is merged back into berk.

I'm good with @aclum & @eecavanna 's lists for more specific schema changes that don't have downstream effects.

@turbomam where would you like this more "officially" captured?

We also need to make a PR template. Not many people have provided feedback on what that template should look like
#1995

from nmdc-schema.

turbomam avatar turbomam commented on July 19, 2024

@aclum does you exception 1. mean only python changes in nmdc-schema only, not berkeley-schema-fy24? I would want to all changes there too.

Otherwise I agree with the conclusions here.

from nmdc-schema.

aclum avatar aclum commented on July 19, 2024
  1. would include python changes in both nmdc-schema, which would then get a back merge to berkeley-schema-fy24, and changes in berkeley-schema-fy24 if need to make them compatible with that version of the schema.

from nmdc-schema.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.