Comments (6)
For the exceptions framework (decision framework), I propose this rule:
- If the PR consists of changes to the
nmdc_schema/migrators
directory only, then it can be merged in after the typical developer-level review/approval (i.e. without a squad-level discussion/approval).
I expect that situation to arise multiple times during the soft schema freeze.
from nmdc-schema.
see also
from nmdc-schema.
exception framework proposal:
- addition of python scripts to nmdc_schema
- New permissible values for enumerations (ie FileTypeEnum)
- changes to description/comment slots
- schema bug fixes identified during migration and testing on existing features
from nmdc-schema.
We can put the decision in the decision log? There's a note and decision logged in the metadata meeting note
- Schema changes that have any downstream effects will not be permitted after May 31st(June 14th). Downstream relates to requirements for runtime, workflows, products, or any other components of NMDC
- Changes to the schema that do not have downstream effects, are simply modeling changes that can be later implemented can be done on a branch and merged in AFTER review and evaluation.
- Schema changes that donβt have downstream effects
Decision: Berkeley schema & nmdc-main schema changes should be reviewed and discussed with the team because nmdc-main schema is merged back into berk.
I'm good with @aclum & @eecavanna 's lists for more specific schema changes that don't have downstream effects.
@turbomam where would you like this more "officially" captured?
We also need to make a PR template. Not many people have provided feedback on what that template should look like
#1995
from nmdc-schema.
@aclum does you exception 1.
mean only python changes in nmdc-schema
only, not berkeley-schema-fy24
? I would want to all changes there too.
Otherwise I agree with the conclusions here.
from nmdc-schema.
- would include python changes in both nmdc-schema, which would then get a back merge to berkeley-schema-fy24, and changes in berkeley-schema-fy24 if need to make them compatible with that version of the schema.
from nmdc-schema.
Related Issues (20)
- backmerge issue with ID mention pattern constraints on WorkflowExecution HOT 3
- `berkeley-schema-fy24`: Implement migrator that adds `replaces` field to `WorkflowChain` documents HOT 1
- `berkeley-schema-fy24`: Delete obsolete code, including code obsoleted by Berkeley schema changes
- write a notebook report class.slot paths that take a ControlledTermValue* range
- Remodel class that aggregates steps of `WorkflowExecution` for easier schema traversal HOT 1
- `has_input`, `has_output`, and `has_process_parts` slots on `ProtocolExecution` need pattern constraints
- `berkeley-schema-fy24`: Facilitate access to `nmdc_materialized_patterns` schema via PyPI package HOT 2
- Delete Class WorkflowChain in Berkeley schema HOT 2
- `berkeley-schema-fy24`: Implement super migrator that runs all partial migrators in correct order HOT 1
- Find a home for these comments taken from `src/scripts/report_biosamples_per_study.py`
- check if classes associated with `alternative_identifiers` can use ANY `alternative_identifiers` HOT 5
- Migrations: Make it easier to test migrators against a Mongo database
- `berkeley-schema-fy24`: Update migrators to account for `WorkflowChain` class being removed
- Publish schema to PyPI via GitHub Release `v10.5.4` HOT 1
- Migrations: Implement "no op" migrator from `v10.4.0` to `v10.5.4`
- `berkeley-schema-fy24`: Some migrators use incorrect collection name (instead of `mags_set`)
- Rename branches to eliminate Berkeley commits from `main` HOT 6
- 2024-06-18 `id` pattern validation summaries and SPARQL-based referential integrity checks on MongoDB contents with and without migration HOT 6
- Facilitate access to `nmdc_materialized_patterns` schema variant via PyPI package HOT 2
- produce a nmdc-schema YAML artifact with deprecated elements included HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nmdc-schema.