microsoft / powerbi-visuals-utils-typeutils

Type utility interfaces for creating powerbi custom visuals

Microsoft Power BI visuals TypeUtils

TypeUtils is a set of functions and classes in order to extend the basic types for Power BI custom visuals

Usage

Learn how to install and use the TypeUtils in your custom visuals:

• Usage Guide

Contributing

• Read our contribution guideline to find out how to contribute bugs fixes and improvements
• Issue Tracker

License

See the LICENSE file for license rights and limitations (MIT).

powerbi-visuals-utils-typeutils's Issues

This repo is missing important files

There are important files that Microsoft projects should all have that are not present in this repository. A pull request has been opened to add the missing file(s). When the pr is merged this issue will be closed automatically.

Microsoft teams can learn more about this effort and share feedback within the open source guidance available internally.

Merge this pull request

floorWithPrecision returns unexpected result?

Double.floorWithPrecision(5.96, 0.1); returns 6.

Is it expected result?

Double.roundToPrecision rounding issue

There is an issue with this line in Double.roundToPrecision

powerbi-visuals-utils-typeutils/src/double.ts

Line 379 in c6485ad

let result = Math.round(x / precision) * precision;

I encountered this issue because the formattingutils use this function in the valueFormatter so that for a common configuration the formatting of e.g. 0.2 returns 0.19999999999999998. See this issue for details.
I found this thread which discusses different rounding to precision implementations and their caveats. The one that is working for me is this implementation

function roundToTwo(num) {    
    return +(Math.round(num + "e+2")  + "e-2");
}

which I adjusted to this

function bestRound(x: number, precision: number) {
  let p = Math.abs(precision);
  let p1 = precision > 0 ? `-${p}` : `+${p}`;
  let p2 = precision > 0 ? `+${p}` : `-${p}`;
  return +(Math.round(x + `e${p1}` as any)  + `e${p2}`);
}

although it's difficult to say if there are edge cases where it won't work. You can see my fix here. Let me know if I should send a pull request.

Maximum font size cannot be larger than 40

The PR #10 addresses this issue:

Allows visuals to use bigger fonts than 40. (Example: Synoptic panel). The number 100 is an arbitrary choice. We've seen scenarios where we wanted to use font size 72.

Uncaught TypeError: Cannot read property 'PixelConverter' of undefined

Hi there,

I added and was using powerbi.extensibility.utils.type.PixelConverter into my custom visual and it was working fine for some time then it started giving me following error.


I tried removing node_modules and installed all the library again but still I am getting this issue. Can you please help me solve this issue? following are the imports in package.json and pbiviz.json

package.json

{
  "name": "advancecard",
  "version": "1.0.7",
  "dependencies": {
    "@types/d3": "^3.5.41",
    "d3": "^3.5.17",
    "powerbi-visuals-utils-dataviewutils": "1.2.0",
    "powerbi-visuals-utils-formattingutils": "^3.0.2",
    "powerbi-visuals-utils-svgutils": "^1.1.0",
    "powerbi-visuals-utils-tooltiputils": "^1.0.1",
    "powerbi-visuals-utils-typeutils": "^1.1.0",
    "typescript": "^2.8"
  }
}

pbivz.json

  "externalJS": [
    "node_modules/powerbi-visuals-utils-dataviewutils/lib/index.js",
    "node_modules/d3/d3.js",
    "node_modules/globalize/lib/globalize.js",
    "node_modules/globalize/lib/cultures/globalize.cultures.js",
    "node_modules/powerbi-visuals-utils-dataviewutils/lib/index.js",
    "node_modules/powerbi-visuals-utils-formattingutils/lib/index.js",
    "node_modules/powerbi-visuals-utils-tooltiputils/lib/index.js",
    "node_modules/powerbi-visuals-utils-typeutils/lib/index.js",
    "node_modules/powerbi-visuals-utils-svgutils/lib/index.js"
  ]