Search highlights are gone if the window is resized about terminal

[tusharsnx]

If you have already introduced the throttled func, you still need to clear the search at the time of resize otherwise they render relative to the old buffer 🤔

[tusharsnx]

Also, we don't really need to clear the highlights (and we should absolutely not because that's going to be announced as results being cleared 🤔). All we need is when there's a pending call to refresh the highlights, we should mark current results within Search to be not fresh. So, when the renderer tries to read in between the pending call, it should get an empty list for the duration. Later, the throttled call would refresh the results and mark them as fresh again.

[lhecker]

[...] and we should absolutely not because that's going to be announced as results being cleared

BTW I've removed the event and replaced it with

• An "output is idle" event, which gets thrown whenever there wasn't any output for 100ms
• ControlCore::Search() returns a SearchResults struct

TermControl owns ControlCore and because of that IMHO the former should be in charge of deciding when to call into the latter. Whenever ControlCore raises this generic "output is idle" event, TermControl calls _core.Search() and handles updating the UI synchronously. That way no search update event is needed.

So, when the renderer tries to read in between the pending call, it should get an empty list for the duration. Later, the throttled call would refresh the results and mark them as fresh again.

I may be misunderstanding you again, but you're suggesting to clear the search results after the reflow and then trigger a search update asynchronously, right? That's the same thing I had in mind. 🙂

[tusharsnx]

They shouldn't stick around after a resize

Does #16611 fix this for you?

[lhecker]

I may be doing something wrong, but it seems to still occur.

[lhecker]

BTW something funny is happening when I resize the app (this is a debug build so it's a little laggy):

96rPQXu7URrfxUdb.mp4

This is with my changes in to redo the search on resize, but I haven't touched the search code so I think it may have a bug.

[lhecker]

OH.