GithubHelp home page GithubHelp logo

minetest-mods / i3 Goto Github PK

View Code? Open in Web Editor NEW
41.0 8.0 26.0 1.44 MB

:rocket: A next-generation inventory for Minetest 5.6+

License: Other

Lua 99.83% Shell 0.17%
minetest mod inventory crafting guide ui gui craft

i3's People

Contributors

kilbith avatar smalljoker avatar wsor4035 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

i3's Issues

issue with Techage modpack on new i3 version

when starting minetest server 5.4.1 compiled from source for arm64 with i3 1.5.1 and techage modpack on a server it gives this error

2021-12-14 15:56:47: ACTION[Main]: Server: Shutting down 2021-12-14 15:56:47: ERROR[Main]: ModError: Failed to load and run script from /home/pi/minetest-5.4.1/bin/../mods/i3/init.lua: 2021-12-14 15:56:47: ERROR[Main]: /home/pi/minetest-5.4.1/bin/../mods/i3/init.lua:18: assertion failed! 2021-12-14 15:56:47: ERROR[Main]: stack traceback: 2021-12-14 15:56:47: ERROR[Main]: [C]: in function 'assert' 2021-12-14 15:56:47: ERROR[Main]: /home/pi/minetest-5.4.1/bin/../mods/i3/init.lua:18: in function 'lf' 2021-12-14 15:56:47: ERROR[Main]: /home/pi/minetest-5.4.1/bin/../mods/i3/init.lua:72: in main chunk

it stops minetest from starting
when starting minetest with i3 1.5.1 and techage modpack on minetest linux desktop 5.4.1

2021-12-14 10:59:05: ERROR[Main]: ModError: Runtime error from mod 'i3' in callback on_mods_loaded(): /usr/share/minetest/builtin/game/item.lua:22: attempt to index local 'img1' (a nil value) 2021-12-14 10:59:05: ERROR[Main]: stack traceback: 2021-12-14 10:59:05: ERROR[Main]: /usr/share/minetest/builtin/game/item.lua:22: in function 'draw_cube' 2021-12-14 10:59:05: ERROR[Main]: (load):307: in function 'get_cube' 2021-12-14 10:59:05: ERROR[Main]: (load):321: in function 'init_cubes' 2021-12-14 10:59:05: ERROR[Main]: (load):331: in function 'fill_caches' 2021-12-14 10:59:05: ERROR[Main]: /home/dragonfire/.minetest/mods/i3/init.lua:218: in function </home/dragonfire/.minetest/mods/i3/init.lua:217> 2021-12-14 10:59:05: ERROR[Main]: /usr/share/minetest/builtin/game/register.lua:422: in function </usr/share/minetest/builtin/game/register.lua:406> 2021-12-14 10:59:05: ERROR[Main]: Check debug.txt for details. 2021-12-14 10:59:05: ACTION[Main]: Server: Shutting down

it works fine with out the techage modpack and it worked with a older version of i3
and i did make sure to disable unified inventory

skinsdb error

Hi,
I get this error with skinsdb and more used textures (attached - skinsdb_textures.zip)

2021-02-27 11:45:39: ERROR[Main]: Invalid dropdown element(8): '0,6.100000;3.55,0.6;skins;Sam,horrible spring sdzen,Summer,lisa,Ladyvioletkitty,Mammu,Jayne,blue girl,Adventer girl,BrightGirl,rize,alejandra,Aurora (child of light),Xenia,stef325,Clo&eacute;,Julia,Morgane,Elf,Angel,Female ang
2021-02-27 11:45:39: ERROR[Main]: el,Elf,Blonde Girl,bikini,White Music Girl,MLP-Fluttershy,Flower Girl,Rin-chan 1,Tahlia,MC cute girls polar bear,Blue Wolf-Girl,Pretresse,bear63681,CreativeFox,FluffyGirl,Nenha,Abril,Custom Skin 1,Black Flower Crown,Name this pls 2,Lilly,Nani,Karita,Athena
2021-02-27 11:45:39: ERROR[Main]: ,Lotte,Yuzuki_Airi,Raina,Marisa,KittyKat_2,KittyKat,Yuzuki_Airi,Black_MagicGirlX(1.2),LadyK,RainbowGirl,Inga,smilla,Sam I,Tuxedo Sam,philipbenr,CaligoPL,Hobo/Homeless person,Naruto,lordphoenixmh,4&deg;district,Gangnam Style,Finn The Adventured,Seth Rollins
2021-02-27 11:45:39: ERROR[Main]: ,Jesus,Renan123,Finnzzin,DanTDM,Esteban,Akatsuki sasuke,Notch,WindHero,Hunky Simon with Jacket,Red-brown-shirt-dude,Bangarng Kid,Oliver_MV,Nero,take bake the night sensei,take bake the night studant,dwarf from lottmob,elf from lottmob,Sokomine,the 10the do
2021-02-27 11:45:39: ERROR[Main]: ctor,Michal VonFlynee,nman3600,war-sloop,Doctor Sam,Esteban II (Cape Version),Link,NejWolf,Lyoligamer,MBB,FisherX,Onyx,vangleidson,Mr Business,Pikachu Boy,chico blanco,Near,abu,Male,MCL 2 Skin,The Green Wizard,Duke Nukem,Mumbo Jumbo,Scientist 2,SirYakari w
2021-02-27 11:45:39: ERROR[Main]: ith clothes,SirYakari without clothes,viv100,AMMOnym,SuperSam,santa,Golden Knight,Wii,Batman,Sam Angel,King Sam,RoboCop,star war,WW2 Reich Soldier,Soldier,KyloRen,deadpool,Ashley,Male angel,Police Officer,Cap,iron man(skin iron man 2),TheFlash,zm78(old sku
2021-02-27 11:45:39: ERROR[Main]: lly),King Arthur,StormTrooper,Chewie,Darth Vader,Ducky,Frodo,Man,Elf,LUCAS;1;true'
2021-02-27 11:45:45: ACTION[Main]: Server: Shutting down

It works with smartinventory or sfinv.

expose compressing items

currently i3 supports compressing items(which is a very nice feature) in the inventory, defined in etc/compress.lua, however this is not exposed anywhere in the i3 api so that other mods can register compression. This issue is a request that an api method be exposed for registering item compression within i3

Features and mods support request

Hi,
Just a list of mods support and features I would like to see in your mod

mods
-worldedit interface
-upgrade_packs and more_upgrade
-advmarkers

features
-sethome and home button
-enable recipe in creative mode
-bags ; dont reduce the size of slots (makes it hard to see and manipulate items)
-bags ; bigger capacity

settingtypes.txt bool reading default

Hi,
Default Value from settingtypes.txt is not recognized if you read it with
local item_compression = core.settings:get_bool "i3_item_compression".

You have to set it in settings fist, otherwise you get nil back.

It is better to force teh default value in code
local item_compression = core.settings:get_bool("i3_item_compression", true)

No trash in survival / option

Hi JP.

I know you don't like adding too much settings or changing the gui style, but maybe you could reconsider this.

Many people don't like inventory trash in the survival, but it is very useful in creative.

I use this small patch to remove the buttons in survival:

Patch
diff --git a/init.lua b/init.lua
index 3bb0605..9f308b5 100644
--- a/init.lua
+++ b/init.lua
@@ -1893,9 +1893,13 @@ local function get_ctn_content(fs, data, player, yoffset, ctn_len, award_list, a
 
 	fs(fmt("list[current_player;craft;%f,%f;3,3;]", 0, yoffset + 1.45))
 	fs("image", 3.47, yoffset + 2.69, 0.85, 0.85, PNG.arrow)
-	fs(fmt("list[current_player;craftpreview;%f,%f;1,1;]", 4.45, yoffset + 2.6),
-	   fmt("list[detached:i3_trash;main;%f,%f;1,1;]", 4.45, yoffset + 3.75))
-	fs("image", 4.45, yoffset + 3.75, 1, 1, PNG.trash)
+	fs(fmt("list[current_player;craftpreview;%f,%f;1,1;]", 4.45, yoffset + 2.6))--,
+	--   fmt("list[detached:i3_trash;main;%f,%f;1,1;]", 4.45, yoffset + 3.75))
+	--fs("image", 4.45, yoffset + 3.75, 1, 1, PNG.trash)
+	if core.is_creative_enabled(name) then
+		fs(fmt("list[detached:i3_trash;main;%f,%f;1,1;]", 4.45, yoffset + 3.75))
+		fs("image", 4.45, yoffset + 3.75, 1, 1, PNG.trash)
+	end
 
 	local yextra = 5.5
 
@@ -2388,11 +2392,12 @@ local function get_inventory_fs(player, data, fs)
 	fs("scroll_container_end[]")
 
 	local btn = {
-		{"trash", ES"Trash all items"},
+		--{"trash", ES"Trash all items"},
 		{"sort_az", ES"Sort items (A-Z)"},
 		{"sort_za", ES"Sort items (Z-A)"},
 		{"compress", ES"Compress items"},
 	}
+	if core.is_creative_enabled(name) then table.insert(btn, 1, {"trash", ES"Trash all items"}) end
 
 	for i, v in ipairs(btn) do
 		local btn_name, tooltip = unpack(v)

It would be even better with some settingtype, so everyone can adapt this great gui to his game play style.

Chests no longer close

The default chests which have a lid open animation, get stuck in the open state.

When I remove i3 chests return to normal.

Honestly I thought it was due to model_aliases but to my dismay, I have no idea what is the cause of this.

Shift click for armor and bags (remove the scrolling?)

This is another feature request :-D
Shift clicking on items to get them from your inventory to chests and the crafting table is just really useful and I would like to have this also for the bags and armor in i3.
I suggest to add the crafting table to the list of bags, armor, ...
Also this would remove the scrolling down to get to the bags and armor slots and in my opinion there is no reason why these should be "on the same page" as the crafting table.

Game gives me this error message when i try to load a world

After I installed this mod i get the following error message:
2022-01-02 12:31:56: ERROR[Main]: ModError: Failed to load and run script from /home/dominic/.minetest/mods/i3/init.lua:
2022-01-02 12:31:56: ERROR[Main]: /home/dominic/.minetest/mods/i3/init.lua:72: assertion failed!
2022-01-02 12:31:56: ERROR[Main]: stack traceback:
2022-01-02 12:31:56: ERROR[Main]: [C]: in function 'lf'
2022-01-02 12:31:56: ERROR[Main]: /home/dominic/.minetest/mods/i3/init.lua:72: in main chunk

Show recipes for creative players

Is there a way for players with the creative privilege to also see the recipes?
This would be useful especially for administrators.

Crash when "Preview the waypoint area"

I used the latest version from the minetest db, which should be 1.5.1, and have a crash in local game, when clicking on "Preview the waypoint area".
The error message is:

WARNING[Server]: Undeclared global variable "bit" accessed at (load):273
ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod '' in callback on_playerReceiveFields(): (load):273: attempt to index global 'bit' (a nil value)
ERROR[Main]: stack traceback:
ERROR[Main]: (load):273: in function 'get_isometric_view'
ERROR[Main]: (load):375: in function 'get_waypoint_fs'
ERROR[Main]: (load):518: in function 'get_container'
ERROR[Main]: (load):699: in function 'formspec'
ERROR[Main]: (load):1498: in function 'make_fs'
ERROR[Main]: (load):169: in function 'fields'
ERROR[Main]: (load):460: in function <(load):422>
ERROR[Main]: ../minetest/builtin/game/register.lua:422: in function <../minetest/builtin/game/register.lua:406>

More keybindings

It'd be perfect to right-click an item to get it. Currently you're forced to double-click an item to get it, which isn't very intuitive.
Also, several buttons could be keybinded (notably tabs).

Needs minetest/minetest#8679 or a better approach by @v-rob

API for backpacks

The current backpack support is hard-coded and the recipes depend on minetest-game/farming for string. This seems out-of-place in what should be a generic inventory implementation.

Proposed solution:

  1. Define no backpacks by default
  2. Create a new API call i3.register_backpack(itemid, backpack_defn) which takes an existing registered item and adds the backpack behaviour to it. backpack_defn is a table with whatever properties make sense for a backpack (I imagine slot width and height, at a minimum).

If desired, the existing backpacks could be extracted to a companion mod i3-backpacks which uses the new call. This would have the added benefit of serving as an example implementation.

Bug: restart causes item loss past slot 36 when using bags

see issue title, another thing I have noticed when working on a project that uses i3
steps to reproduce

  1. add a bag in the bag slot
  2. add any item past slot 36 and a a item before slot 36
  3. close and reopen world
  4. observe item before slot 36 is still there, and item past slot 36 is gone

Way to WorldEdit interface

PLease add ability to get WorldEdit GUI or button for Unified_Inventory(which already supports WorldEdit GUI)

Hot bar X position not consistent

This is a very minor complaint, but I've noticed that the X position the hotbar starts can change by 2 pixels on startup. I only noticed because I'm trying to get the hudbars mod to line up with it perfectly.

Sometimes, the left x margin (number of pixels between the left of the screen, and the left-most part of the hotbar) is 1024 pixels, sometimes it's 1026. Weirdly the right x margin is consistent - it's always 1026 pixels. This is with a 2560 wide screen. I've scaled the GUI to 1.5 but that doesn't seem to affect i3 (which should probably be another issue ;) ).

I'm using latest i3 on Minetest 5.4.1.

init.lua:2513: attempt to call method 'get_local_animation' (a nil value)

Hi,
this happens when a mesecon nodebreaker tries to break a node:

app_1    | 2021-05-10 13:30:55: ERROR[Main]: ServerError: AsyncErr: environment_Step: Runtime error from mod 'i3' in callback environment_Step(): /config/.minetest/mods/i3/init.lua:2513: attempt to call method 'get_local_animation' (a nil value)
app_1    | 2021-05-10 13:30:55: ERROR[Main]: stack traceback
app_1    | 2021-05-10 13:30:55: ERROR[Main]:    /config/.minetest/mods/i3/init.lua:2513: in function 'formspec
app_1    | 2021-05-10 13:30:55: ERROR[Main]:    /config/.minetest/mods/i3/init.lua:2238: in function 'make_fs
app_1    | 2021-05-10 13:30:55: ERROR[Main]:    /config/.minetest/mods/i3/init.lua:2258: in function 'set_fs'                        
app_1    | 2021-05-10 13:30:55: ERROR[Main]:    /config/.minetest/mods/i3/init.lua:2756: in function 'func
app_1    | 2021-05-10 13:30:55: ERROR[Main]:    /usr/share/minetest/builtin/profiler/instrumentation.lua:106: in function 'callback'                          
app_1    | 2021-05-10 13:30:55: ERROR[Main]:    /usr/share/minetest/builtin/game/item.lua:650: in function 'on_dig
app_1    | 2021-05-10 13:30:55: ERROR[Main]:    /config/.minetest/mods/pipeworks/wielder.lua:345: in function 'act
app_1    | 2021-05-10 13:30:55: ERROR[Main]:    /config/.minetest/mods/pipeworks/wielder.lua:111: in function 'wielder_on'                                                                   
app_1    | 2021-05-10 13:30:55: ERROR[Main]:    /config/.minetest/mods/pipeworks/wielder.lua:147: in function 'action_on'                                                                                   
app_1    | 2021-05-10 13:30:55: ERROR[Main]:    /config/.minetest/mods/mesecons/mesecons/internal.lua:192: in function </config/.minetest/mods/mesecons/mesecons/internal.lua:185>    
app_1    | 2021-05-10 13:30:55: ERROR[Main]:    /config/.minetest/mods/mesecons/mesecons/actionqueue.lua:137: in function 'execute'              
app_1    | 2021-05-10 13:30:55: ERROR[Main]:    /config/.minetest/mods/mesecons/mesecons/actionqueue.lua:111: in function </config/.minetest/mods/mesecons/mesecons/actionqueue.lua:73> 
app_1    | 2021-05-10 13:30:55: ERROR[Main]:    /usr/share/minetest/builtin/game/register.lua:422: in function </usr/share/minetest/builtin/game/register.lua:406> 

Using these mods:
https://github.com/minetest-mods/mesecons
https://gitlab.com/VanessaE/pipeworks

Android version of game crash server

Hi, at first, thanks for really wesome work on this mod.

But recent progress on this mod break possibility to be used on Android devices with MT 5.3 ( I think that few days back.. it was working all right).

This is log from server after server crash when Android device was connected.

2021-01-25 00:18:14: ERROR[Main]: ServerError: AsyncErr: environment_Step: Runtime error from mod 'wieldview' in callback environment_Step(): ...r\Minetest-server\minetest-5.4.0\bin..\mods\i3\init.lua:2006: attempt to index local 'data' (a nil value)
2021-01-25 00:18:14: ERROR[Main]: stack traceback:
2021-01-25 00:18:14: ERROR[Main]: ...r\Minetest-server\minetest-5.4.0\bin..\mods\i3\init.lua:2006: in function 'make_fs'
2021-01-25 00:18:14: ERROR[Main]: ...r\Minetest-server\minetest-5.4.0\bin..\mods\i3\init.lua:2035: in function 'func'
2021-01-25 00:18:14: ERROR[Main]: ...ver\minetest-5.4.0\bin..\mods\3d_armor\3d_armor/api.lua:172: in function 'run_callbacks'
2021-01-25 00:18:14: ERROR[Main]: ...ver\minetest-5.4.0\bin..\mods\3d_armor\3d_armor/api.lua:189: in function 'update_player_visuals'
2021-01-25 00:18:14: ERROR[Main]: ...r\minetest-5.4.0\bin..\mods\3d_armor\wieldview\init.lua:64: in function 'update_wielded_item'
2021-01-25 00:18:14: ERROR[Main]: ...r\minetest-5.4.0\bin..\mods\3d_armor\wieldview\init.lua:75: in function 'func'
2021-01-25 00:18:14: ERROR[Main]: ...st-server\minetest-5.4.0\bin..\builtin\common\after.lua:20: in function <...st-server\minetest-5.4.0\bin..\builtin\common\after.lua:5>
2021-01-25 00:18:14: ERROR[Main]: ...t-server\minetest-5.4.0\bin..\builtin\game\register.lua:433: in function <...t-server\minetest-5.4.0\bin..\builtin\game\register.lua:417>
2021-01-25 00:18:14: ERROR[Main]: stack traceback:

I'll hope that You'll fix this.

Thanks for Your work Sharp

Crash when clicking "unknown" nodes in recipe preview

Not sure if this is a bug in the i3 mod or not but if a mod registers a recipe with not available nodes (in this case scifi_nodes had registered a recipe with a basic_materials:plastic in it)
they get a preview as a crafting recipe and crash the engine if clicked on:

AsyncErr: ServerThread::run Lua: Runtime error from mod 'i3' in callback on_playerReceiveFields(): /home/thomas/.minetest/mods/i3/init.lua:1516: attempt to index local 'def' (a nil value)
stack traceback:
	/home/thomas/.minetest/mods/i3/init.lua:1516: in function 'get_header'
	/home/thomas/.minetest/mods/i3/init.lua:1636: in function 'get_panels'
	/home/thomas/.minetest/mods/i3/init.lua:1799: in function 'make_fs'
	/home/thomas/.minetest/mods/i3/init.lua:1808: in function 'set_fs'
	/home/thomas/.minetest/mods/i3/init.lua:2228: in function '?'
	...thomas/git/minetest/bin/../builtin/game/register.lua:433: in function <...thomas/git/minetest/bin/../builtin/game/register.lua:417>

Anyway: awesome mod 👍

Something seriously wrong.

There is something seriously wrong here, I have extensively tested i3 on a world with no other mods and I am still able to trigger this strange bug at what seems like completely random interactions with other mods. Other players experience it online, so it's not just my client, it's baffling. It seems to work fine on some servers with particular mods but there's something that i3 is doing that I cant put my finger on, that when combined with other mods in some way, causes it to just completely break formspecs of every other mod in the game.

I run a number of servers, I have only got i3 working on one of them.

It made me think it was due to the order i3 was loaded in with other mods, but really, I have no idea at this point.

It is a shame because i3 is a nice inventory, but I just can't use it, all these problems vanish across all servers when I remove i3.

i3 is 100% absolutely breaking formspecs for all mods including the minetest_game under circumstances that I cannot isolate, I cannot work out whats causing it, why it seems to happen randomly in certain conditions where other mods are installed on the server, I have tried so many combinations, i3 just seems to randomly decide to break formspecs or not break them and there is no logical root to figuring out why. Something is very wrong.

skinsdb - skin set without i3

If you set the skin without i3, then later in i3-skinsdb drop-down list the skin name is not correct.
(e.g. if you switch from sfinv to i3)

You could get the actual skin name by skins.get_player_skin(player).name

Forces loop of main menu

With the mod installed there is an issue where it force loops the main menu. Pressing escape returns to the main menu instead of closing it. Pressing continue button also does the same.

Minetest server info:

Minetest 5.4.0 (Linux)
Using Irrlicht 1.8.4
Using Lua 5.1.5
BUILD_TYPE=Release
RUN_IN_PLACE=0
USE_CURL=1
USE_GETTEXT=0
USE_SOUND=1
USE_FREETYPE=1

Runtime error from mod 'skinsdb' in callback on_joinplayer()

2022-02-19 08:20:42: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'skinsdb' in callback on_joinplayer(): (load):19: core.check_player_privs expects a player or playername as argument.
2022-02-19 08:20:42: ERROR[Main]: stack traceback:
2022-02-19 08:20:42: ERROR[Main]: 	[C]: in function 'error'
2022-02-19 08:20:42: ERROR[Main]: 	...home/x/mtnew/minetest/bin/../builtin/game/misc.lua:23: in function 'check_player_privs'
2022-02-19 08:20:42: ERROR[Main]: 	(load):19: in function 'is_creative_enabled'
2022-02-19 08:20:42: ERROR[Main]: 	(load):1258: in function 'hide_items'
2022-02-19 08:20:42: ERROR[Main]: 	(load):1275: in function 'get_items_fs'
2022-02-19 08:20:42: ERROR[Main]: 	(load):1496: in function 'make_fs'
2022-02-19 08:20:42: ERROR[Main]: 	(load):170: in function 'func'
2022-02-19 08:20:42: ERROR[Main]: 	...ilder/worldmods/armor_mods/3d_armor/3d_armor/api.lua:183: in function 'run_callbacks'
2022-02-19 08:20:42: ERROR[Main]: 	...orlds/builder/worldmods/system_mods/skinsdb/init.lua:49: in function 'update_player_visuals'
2022-02-19 08:20:42: ERROR[Main]: 	...ilder/worldmods/armor_mods/3d_armor/3d_armor/api.lua:358: in function 'set_player_armor'
2022-02-19 08:20:42: ERROR[Main]: 	...worlds/builder/worldmods/system_mods/skinsdb/api.lua:44: in function 'update_player_skin'
2022-02-19 08:20:42: ERROR[Main]: 	...orlds/builder/worldmods/system_mods/skinsdb/init.lua:61: in function '?'
2022-02-19 08:20:42: ERROR[Main]: 	.../x/mtnew/minetest/bin/../builtin/game/register.lua:425: in function <.../x/mtnew/minetest/bin/../builtin/game/register.lua:409>

Guys you can't just close this issue, we need to workout why this is happening. The skinsdb and 3d_armor mods are the latest versions. Why is this happening? Minetest server and client 5.5.0.

I will connect to a server on a fresh boot (from an account with creative), everything is fine, I will disconnect and reconnect with the same account and on the re-connect it throws me this error right as my player joins the game. Every time without fail.

Removing skinsdb solves this problem.

Failed to load and run script

2021-03-17 21:42:24: ERROR[Main]: ModError: Failed to load and run script from /home/vfc/.minetest/mods/i3-main/init.lua: 2021-03-17 21:42:24: ERROR[Main]: /home/vfc/.minetest/mods/i3-main/init.lua:2553: attempt to call a nil value 2021-03-17 21:42:24: ERROR[Main]: stack traceback: 2021-03-17 21:42:24: ERROR[Main]: /home/vfc/.minetest/mods/i3-main/init.lua:2553: in main chunk

Turn off progressive mode in creative

Hi,

could you please turn off progressive mod in creative?
All items have to be available in creative mod. Turning off the setting is a little bit annoying :)

I use this little patch for it. I'm not sure if this is the best way, but it works.

diff --git a/init.lua b/init.lua
index 0a953e7..619952d 100644
--- a/init.lua
+++ b/init.lua
@@ -12,7 +12,7 @@ local toolrepair
 
 local tabs = {}
 
-local progressive_mode = core.settings:get_bool "i3_progressive_mode"
+local progressive_mode = core.settings:get_bool "i3_progressive_mode" and not(core.is_creative_enabled())
 local damage_enabled = core.settings:get_bool "enable_damage"
 
 local __3darmor, __skinsdb, __awards

i3 heigh

Hi,

could you make i3 a little bit higher?
There is enough place up.

It would be great to have the some basic information visible, like backpack used, first waitpoint, ... .

Something like this:
obrázok

Crash on clicking item in "items" tab

On version: master (fresh pull, from source), NOT using LuaJIT

Stack trace:

2021-04-06 03:46:22: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod '' in callback on_playerReceiveFields(): /home/world/repos/minetest/bin/../mods/i3/init.lua:672: attempt to call method 'get_short_description' (a nil value)
2021-04-06 03:46:22: ERROR[Main]: stack traceback:
2021-04-06 03:46:22: ERROR[Main]: 	/home/world/repos/minetest/bin/../mods/i3/init.lua:672: in function 'get_desc'
2021-04-06 03:46:22: ERROR[Main]: 	/home/world/repos/minetest/bin/../mods/i3/init.lua:1650: in function 'get_header'
2021-04-06 03:46:22: ERROR[Main]: 	/home/world/repos/minetest/bin/../mods/i3/init.lua:1791: in function 'get_panels'
2021-04-06 03:46:22: ERROR[Main]: 	/home/world/repos/minetest/bin/../mods/i3/init.lua:2095: in function 'make_fs'
2021-04-06 03:46:22: ERROR[Main]: 	/home/world/repos/minetest/bin/../mods/i3/init.lua:2111: in function </home/world/repos/minetest/bin/../mods/i3/init.lua:2106>
2021-04-06 03:46:22: ERROR[Main]: 	(tail call): ?
2021-04-06 03:46:22: ERROR[Main]: 	/home/world/repos/minetest/bin/../mods/i3/init.lua:2978: in function '?'
2021-04-06 03:46:22: ERROR[Main]: 	...orld/repos/minetest/bin/../builtin/game/register.lua:425: in function <...orld/repos/minetest/bin/../builtin/game/register.lua:409>

Which points to this section of init.lua:

local function get_desc(item)
	if sub(item, 1, 1) == "_" then
		item = sub(item, 2)
	end

	local def = reg_items[item]

	if def then
		local desc = ItemStack(item):get_short_description()

		if true_str(desc) then
			desc = desc:trim()

			if not find(desc, "%u") then
				desc = toupper(desc)
			end
			return desc

		elseif true_str(item) then
			return toupper(match(item, ":(.*)"))
		end
	end

	return S("Unknown Item (@1)", item)
end

According to the docs get_short_description() should exist 🤷‍♂️ Maybe this is a Minetest bug?
For now I have changed the line to ItemStack(item):get_definition()["description"], which works, but I don't think this should be necessary.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.