minetest-mods / mg Goto Github PK

is this the intended behavior? just a question really.

I am using experimental mapgen (mg). I'm not sure if this is an mg issue, caverealms issue, or subterrane issue--I looked at the line in question, which uses biomemap, a local variable which should contain the result of minetest.get_mapgen_object("biomemap"). I don't know enough to know why get_mapgen_object would ever return nil after looking up its meaning. If I restart the server, it works for a while, but when trying to dig deeper in a certain location the server crashes. Apparently the problem happens when a caverealm generates.

Seed: BagEnd
Location: /teleport 17,-566,98 (then start digging down)
MapGen: v7
minetest version: 0.5.0-dev (~2018-02-21)
mapgen mods:

• mg
• subterrane
• caverealms (FaceDeer's fork of caverealms which is integrated with mapgen v7's perlin noise and uses subterrane)
• magma_conduits
• minor mapgen mods: moreores, techic, ... for others see https://github.com/expertmm/EnlivenMinetest/blob/master/etc/game-install-ENLIVEN

2018-02-23 19:37:29: ACTION[Main]: [playereffects] Server shuts down. Rescuing data into playereffects.mt
2018-02-23 19:37:29: ACTION[Main]: [playereffects] Wrote playereffects data into /home/owner/.minetest/worlds/FCAWorldB/playereffects.mt.
2018-02-23 19:37:30: ACTION[Main]: [fishing] Server shuts down. saving trophies table
2018-02-23 19:37:31: ERROR[Main]: ServerError: AsyncErr: Lua: finishGenRuntime error from mod 'caverealms' in callback environment_OnGenerated(): ...al/share/minetest/games/ENLIVEN/mods/subterrane/init.lua:181: attempt to index local 'biomemap' (a nil value)
2018-02-23 19:37:31: ERROR[Main]: stack traceback:
2018-02-23 19:37:31: ERROR[Main]: ...al/share/minetest/games/ENLIVEN/mods/subterrane/init.lua:181: in function <...al/share/minetest/games/ENLIVEN/mods/subterrane/init.lua:116>
2018-02-23 19:37:31: ERROR[Main]: /usr/local/share/minetest/builtin/game/register.lua:420: in function </usr/local/share/minetest/builtin/game/register.lua:400>

Without mg installed, at least one caverealm generates without issues (same seed as above, but new world with no mg):
/teleport -25,-971,121
Since it only happens with mg installed, I moved this issue from FaceDeer/minetest-caverealms#2

local well = {
    {
        {C, C, C, C},
        {C, C, C, C},
        {C, C, C, C},
        {C, C, C, C},
    },
    {
        {C,  C,  C, C},
        {C, WS, WS, C},
        {C, WS, WS, C},
        {C,  C,  C, C},
    },
    {
        {C,  C,  C, C},
        {C, WS, WS, C},
        {C, WS, WS, C},
        {C,  C,  C, C},
    },
    {
        {C,  C,  C, C},
        {C, WS, WS, C},
        {C, WS, WS, C},
        {C,  C,  C, C},
    },
    {
        {C,  C,  C, C},
        {C, WS, WS, C},
        {C, WS, WS, C},
        {C,  C,  C, C},
    },
    {
        {C,  C,  C, C},
        {C, WS, WS, C},
        {C, WS, WS, C},
        {C,  C,  C, C},
    },
    {
        {C, C, C, C},
        {C, A, A, C},
        {C, A, A, C},
        {C, C, C, C},
    },
    {
        {FW, A, A, FW},
        { A, A, A,  A},
        { A, A, A,  A},
        {FW, A, A, FW},
    },
    {
        {FW, A, A, FW},
        { A, A, A,  A},
        { A, A, A,  A},
        {FW, A, A, FW},
    },
    {
        {FW, A, A, FW},
        { A, A, A,  A},
        { A, A, A,  A},
        {FW, A, A, FW},
    },
    {
        {C, C, C, C},
        {C, C, C, C},
        {C, C, C, C},
        {C, C, C, C},
    },
}

{sizex=1, sizez=1, ymin=-5, ymax=5, scm=well, no_rotate=true}, only spawns an incomplete well
{sizex=2, sizez=1, ymin=-5, ymax=5, scm=well, no_rotate=true}, crashes
{sizex=1, sizez=2, ymin=-5, ymax=5, scm=well, no_rotate=true}, puts one column of ignore nodes next to building

Currently if you try to run this in Minetest 0.4.14 or newer you get an error:

ERROR[Main]: ServerError: Lua: Attempt to access external file $HOME/.minetest/mods/mg/schems/cotton_field.we with mod security on.

mg should support the new trees in minetest_game, and also not redefine its own pine tree.

Could you add a readme so one can easily see what the mod does without looking into the code?

Possibly with screenshots.

See:
https://forum.minetest.net/viewtopic.php?f=18&t=18533