mmozuras / vim-github-comment Goto Github PK

What happens when two-factor authentication is enabled on my account:

Install went fine, set my username and it generated a token with correct permissions.

I go into a file, add a comment, and it opens the browser with the link. But no comment appears!

Yes, "show notes" is ticked (and can be ticked), but nothing appears :/

Maybe you could crib the way it's done in https://github.com/mattn/gist-vim? This is a really cool looking plugin, but 2FA users can't use it at the moment.

https://news.ycombinator.com/item?id=5929176

The plugin is failing to comment due to a failure in the GetDiffLineNumber function.

Error detected while processing function GHComment..<SNR>93_GetDiffLineNumber:
line    5:
E684: list index out of range: 0
E15: Invalid expression: split_line[0] - 6
Could not create comment. You may not have the rights. 

I am using git 2.2.2 and vim 7.4.488.

https://github.com/mattn/gist-vim looks for the github user name in one's .gitconfig in the custom [github] section.

[github]
  user = justinmk

The code for this isn't too bad:

if !exists('g:github_user')
  let g:github_user = substitute(s:system('git config --get github.user'), "\n", '', '')
endif

Perhaps vim-github-comment can look for this as an alternative to g:github_user, since vim-github-comment is in the "family" of plugins that use @mattn's webapi. It would be nice to see some convergence of configuration conventions in the various Vim "github plugins".

Tried on windows, installed via vim-plug:

Plug 'mattn/webapi-vim'
Plug 'mmozuras/vim-github-comment'

Seems to download and install fine, but on trying to execute the GHComment command, asks for password, I enter the password, and it gives:

Not Found
github-comment auth failed

Any suggestions? Thanks!