mojo2600 / esp-soil-moisture-sensor Goto Github PK

Hello

Can you explain this?

// Battery Drop Correction to normalize to reading at 3.0V
moisture = vccReading3VSetting.get() * moist_raw / batteryCharge;

Example:
vccReading3VSetting.get() = 958
moist_raw = 750
batteryCharge = 60

8.981 = 958 * 750 / 80

Result 8981.25

it should be less than 1000 or not?

Can you explain it to me?

Sorry for my bad english.

The code for adjusting the sensor reading to the battery level is not working correctly and the reading is then always 0.

In the file "esp-soil-moisture-sensor/src/esp-soil-moisture-sensor.cpp" in the function "getSendTemperature()" there is a Wire.endTransmission() after a Wire.requestFrom().
That Wire.endTransmission() can be removed, it is at the moment at line 197.

Explanation: Common-mistakes#2

There is no need to use a while-loop. If two bytes are requested, then two bytes are available if there was no failure.

  // Request 2 bytes , Msb first to get temperature
  Wire.requestFrom(TMP_ADDR, 2);
  // Read temperature as Celsius (the default)
  if(Wire.available() == 2) {      // changed, while -> if == 2
    int msb = Wire.read();
    int lsb = Wire.read();
                                   // changed, removed Wire.endTransmission
    int rawtmp = msb << 8 | lsb;
    int value = rawtmp >> 4;
    temperature = value * 0.0625;
  }