phoenix 1.6 is unsupported about torch

[cpjolicoeur]

Yes, there is an active Phx 1.6 branch in development to support the 1.6 release. It is not fully completed yet.

You can install an early release candidate from hex if you need it immediately, otherwise you'll need to wait until the next official release comes out that supports Phx 1.6

[cpjolicoeur]

I'll try to cut the RC over to an official release sometime today.

@krainboltgreene if you are interested in helping on the 1.6 updates, I have a branch named cpj/phx_1.6 that is really just some initial work adding a phx 1.6 app to the examples for testing and setting up the test script. My first steps would be to get the 1.6 test app working and the test script passing against it so we know we have a stable baseline that we can start doing refactors against with a passing test case.

I'm not sure how familiar you are with how Torch currently runs its generators, but I'd like to refactor it a bit to make the manipulation and moving around of files a bit cleaner going forward. Open to thoughts and suggestions on this path.

[notslang]

Ah, thanks! I'll try that out.

[krainboltgreene]

@cpjolicoeur Hey, what can I do to help the 1.6 branch get merged?

[cpjolicoeur]

@krainboltgreene Really, I think a large part of the process of how the generators are currently structured needs to be re-worked a decent amount to handle more changes in the future.

That, or we just start dropping support for older versions of Phoenix altogether and cut a new major version with that caveat in the release notes (that the new major version is released in order to drop support for older versions of Phoenix).

The current rc is probably workable on Phoenix 1.6 now, but is/was really just done as a quick "fix" to get it out and working.

Have you tested out the RC @krainboltgreene or @notslang ? If anyone else wants to confirm it works fine "in the wild" then I'm find cutting it as an official release for now, until I can find the time to really clean things up on a larger scale.

[krainboltgreene]

I have, but I bailed because I thought something wasn't done and actually it was just how the scaffolding works in general. I encountered no issues in reality.

I think signing off on a general release is probably fine (I've done it with vcr before), but also if you want help rewriting it all I'd love to pair/work on that in tandem.

[cpjolicoeur]

@notslang @krainboltgreene Version 3.7.1 was released to hex.pm this morning

I'm going to close this ticket in favor of new ticket #278 to track additional codebase changes for 1.6 and forward