The emms-mode-line-cycle from momomo5717

emms-mode-line-cycle's People

Contributors

Stargazers

Watchers

emms-mode-line-cycle's Issues

emms-mode-line-cycle-use-icon-p does not work with EMMS 5.2

As of version 5.2 of EMMS the variable emms-model-line-icon-image-cache no longer exists. It has been replaced by a function. This means that the icon can no longer be displayed by emms-mode-line-cycle.
I have tried to fix this with the following patch:

From d5138746a9b8ed7757acf61329ad74be6140a429 Mon Sep 17 00:00:00 2001
From: Diego Nicola Barbato <[email protected]>
Date: Fri, 10 May 2019 12:23:29 +0200
Subject: [PATCH] Fix compatibility issue with EMMS 5.2.

* emms-mode-line-cycle.el (emms-mode-line-cycle--icon-function): Use
  '(emms-mode-line-icon-generate emms-mode-line-icon-color)' instead of
  'emms-mode-line-icon-image-cache' when emms-version is greater than
  or equal to "5.2".
---
 emms-mode-line-cycle.el | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/emms-mode-line-cycle.el b/emms-mode-line-cycle.el
index dc19529..19b0925 100644
--- a/emms-mode-line-cycle.el
+++ b/emms-mode-line-cycle.el
@@ -200,7 +200,10 @@ If INITIALP is no-nil, initialized."
 If INITIALP is no-nil, initialized."
   (concat " "
           emms-mode-line-icon-before-format
-          (emms-propertize "NP:" 'display emms-mode-line-icon-image-cache)
+          (emms-propertize "NP:" 'display (if (string-version-lessp emms-version "5.2")
+                                              emms-mode-line-icon-image-cache
+                                            (emms-mode-line-icon-generate
+                                             emms-mode-line-icon-color)))
           (emms-mode-line-cycle--playlist-current title initialp)))
 
 ;;;###autoload
-- 
2.21.0

integrate with emms-git

Hi,

This seems useful. Would you be interested in integrating it in upstream EMMS?
Note: you need to assign the copyright either to EMMS directly or Emacs (I don't remember).

Rasmus

Recommend Projects