GithubHelp home page GithubHelp logo

mszell / bikenwgrowth Goto Github PK

View Code? Open in Web Editor NEW
63.0 5.0 6.0 11.24 GB

Source code for the paper "Growing urban bicycle networks", exploring algorithmically the limitations of urban bicycle network growth

License: GNU Affero General Public License v3.0

Jupyter Notebook 71.69% Python 26.41% Shell 1.90%
cycling gis transportation-network urban-planning osmnx network-analysis bicycle-network urban-data-science

bikenwgrowth's People

Contributors

mszell avatar tocunha avatar tylerperlman avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

bikenwgrowth's Issues

Data and plot folders are too large

Super interesting work!

But, it is taking too long to clone it. It downloads 11GB of data :0

I recommend to gitignore the data and plot folders. That'd make it easier to clone the repo :)

Rename `query_checkcities.txt` to `query_checkcities.overpassql`

*.overpassql is now the recommended file extension for Overpass QL: OSM Wiki: Overpass QL § File extension
(Disclaimer: I added that section after some discussion.)
Also, it is the most widely used extension on GitHub, see https://github.com/users/FloEdelmann/projects/2/views/2

I propose to rename all Overpass QL files in this repo to *.overpassql for consistency.

Context: GitHub's syntax highlighting engine requires that 200 repositories use the same file extension before they consider supporting that syntax and file extension: github-linguist/linguist#5890

Deprecation Warnings for execution on HPC

Hey, I wanted to reproduce the results of your paper and analyze further cities.
Until now I was not able to analyze data and would be happy to receive support. I am working on a HPC and not with the notebooks.
After populating the parameters/cities.csv with only one city for the start I set up the environment like the README.md instructs. There certificates get superseded back, I guess this is fine.

The following packages will be SUPERSEDED by a higher-priority channel:

  ca-certificates    conda-forge::ca-certificates-2021.10.~ --> anaconda::ca-certificates-2020.10.14-0

When running the scripts/download.job with slurm in code/setup.py the packages gdal and osr are not found. That is why I changed it to be imported from osgeo as

from osgeo import gdal
from osgeo import osr

Is this valid? After this change Shapely (version 1.8.0) throws warnings multiple times. The version is higher than the one you used (1.7.0).

Cities:   0%|          | 0/1 [00:00<?, ?it/s]
<string>:38: ShapelyDeprecationWarning: Iteration over multi-part geometries is deprecated and will be removed in Shapely 2.0. Use the `geoms` property to access the constituent parts of a multi-part geometry.
Networks:   0%|          | 0/10 [00:00<?, ?it/s]
/home/user/.conda/envs/OSMNX/lib/python3.9/site-packages/osmnx/utils_geo.py:281: ShapelyDeprecationWarning: Iteration over multi-part geometries is deprecated and will be removed in Shapely 2.0. Use the `geoms` property to access the constituent parts of a multi-part geometry.
  for polygon in geometry:

The execution continues and then pyproj (version 3.2.1) throws

Cities:   0%|          | 0/1 [00:00<?, ?it/s]
palma: Creating grid
<string>:110: DeprecationWarning: This function is deprecated. See: https://pyproj4.github.io/pyproj/stable/gotchas.html#upgrading-to-pyproj-2-from-pyproj-1

The version is also higher than the one you have seemed to use (2.6.1.post1).

With ignoring the warnings and continuing to executing the analysis there an error occurs. I guess this occurs because ignoring the warnings of deprecation.

Networks:   0%|          | 0/6 [00:00<?, ?it/s]
Fatal error at src/core/vector.c:1181 : Assertion failed: v->stor_begin != v->end
analysis_all.job: line 16:  7108 Aborted                 ~/.conda/envs/OSMNX/bin/python analysisloop.py

Do you see an obvious mistake or correction?

Creating an environment with the requirements_nonbuiltins.txt also takes the higher package versions as before.
So I created an environment which uses the exact (old) versions given in requirements_nonbuiltins.txt. This also did not result in the awaited behavior but also threw an error in the download process.

Loaded parameters.

Loaded PATH.

/home/user/.conda/envs/OSMNX/lib/python3.9/site-packages/pyproj/__init__.py:89: UserWarning: pyproj unable to set database path.
  _pyproj_global_context_initialize()
Setup finished.

Loaded functions.

Running 01.py
Cities:   0%|          | 0/1 [00:00<?, ?it/s]
Traceback (most recent call last):
  File "/home/user/BikeGrowth/bikenwgrowth/scripts/downloadloop.py", line 11, in <module>
    exec(open("01.py").read())
  File "<string>", line 3, in <module>
  File "/home/user/.conda/envs/OSMNX/lib/python3.9/site-packages/osmnx/geocoder.py", line 101, in geocode_to_gdf
    gdf.crs = settings.default_crs
  File "/home/user/.conda/envs/OSMNX/lib/python3.9/site-packages/geopandas/geodataframe.py", line 199, in __setattr__
    super().__setattr__(attr, val)
  File "/home/user/.conda/envs/OSMNX/lib/python3.9/site-packages/pandas/core/generic.py", line 5500, in __setattr__
    return object.__setattr__(self, name, value)
  File "/home/user/.conda/envs/OSMNX/lib/python3.9/site-packages/geopandas/geodataframe.py", line 423, in crs
    self.geometry.values.crs = value
  File "/home/user/.conda/envs/OSMNX/lib/python3.9/site-packages/geopandas/array.py", line 336, in crs
    self._crs = None if not value else CRS.from_user_input(value)
  File "/home/user/.conda/envs/OSMNX/lib/python3.9/site-packages/pyproj/crs/crs.py", line 479, in from_user_input
    return cls(value, **kwargs)
  File "/home/user/.conda/envs/OSMNX/lib/python3.9/site-packages/pyproj/crs/crs.py", line 326, in __init__
    self._local.crs = _CRS(self.srs)
  File "pyproj/_crs.pyx", line 2352, in pyproj._crs._CRS.__init__
pyproj.exceptions.CRSError: Invalid projection: epsg:4326: (Internal Proj Error: proj_create: no database context specified)

What needs to be changed for the code to run as intended?

ValueError: 'u' is not in list

Hi,

Congratulations for this amazing project!!

I am running locally the project and on the notebook 02 when I try to Download and wrangle data I get this error:

imagem

Thank you

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.