ninito-ph / newtoo-ninitocraft

Personal Minecraft server

Hi 👋 My name's Paulo! I'm a software engineer that loves DevOps and games

👋 I'm a self-driven software engineer with a diverse skillset and strong coding skills. I've coded my first full project way back in high school, and have continued to explore more tech ever since. I have a background in games development, and have worked in small indie studios as well as large FAANG companies. 🎮

newtoo-ninitocraft's Issues

Water Elemental health regen is too high

Using a Diamond Sword with perfectly timed criticals, the Water Elemental's health does not go down

Mobs need to be split into separate files, one for each mob

Issue description

Currently, all mobs are kept in one file per 'faction'. This results in large and unreadable files that require significant scrolling, resulting in an error-prone developer experience. This can be seen at
plugins/MythicMobs/Mobs/D20Mobs.

Desired Resolution

Every mob should be moved into a separate file. For example, the current Banditmobs.yml file contains declarations for:

• Bandit_Swordsman
• Bandit_Bowman
• Bandit_Leader
• Bandit_Horse
• Bandit_Horseman
• Bandit-Rogue
• Bandit_Fighter
• Bandit_Lieutenant
• Bandit_Kingpin

Instead of a single file containing all declarations, there should instead be a folder 'Bandits' containing one .yml file for each of the declared mobs.

Notably, the example above mentions the Bandit mobs, but this bounty requires refactoring ALL mobs declared in /D20Mobs.

Mob skills need to be split into separate files, ideally one skill per file

Issue description

Currently, all mobs skills are kept in one file per 'faction'. This results in large and unreadable files that require significant scrolling, resulting in an error-prone developer experience. This can be seen at
plugins/MythicMobs/Skills.

Desired Resolution

Every skill should be moved into a separate file, unless the skills are intextricably linked. For example, the current BanditMobSkills.yml file contains declarations for over 25 skills.

Instead of a single file containing all declarations, there should instead be a folder 'Bandits' containing one .yml file for each of the declared skills. Notable exceptions arise regarding skills like Bandit_Lieutenant_Call_Start, Bandit_Lieutenant_Call_Step2, Bandit_Lieutenant_Call_Finalize, where the skills are always meant to be used in conjunction, and should be placed in a single file, e.g. Bandit_Lieutenant_Call.

Notably, the example above mentions the Bandit mobs, but this bounty requires refactoring ALL skills declared in /Skills.

Bandit Lieutenant reinforcements call sometimes isn't interrupted

The Bandit_Lieutenant has the Bandit_Lieutenant_Call_Start, Bandit_Lieutenant_Call_Step2, Bandit_Lieutenant_Call_Finalize skills, which summon a number of enemies. This skill is meant to be interrupted if the Lieutenant is attacked during the call.

The call sometimes is not cancelled, despite the Lieutenant being attacked.