noelware / docker-manifest-action Goto Github PK

According to the README, inputs should be the final name of your images (IE the things that are docker manifest push'd, and images should be the list of images that you're merging to create the inputs.

But when running the action, it appears they're the other way around. Given the following input:

- uses: Noelware/[email protected]
  with:
    inputs: test:master
    images: test:77762fb4d2eb086d2bc806c3aaa9f35db2f08801-x64,test:77762fb4d2eb086d2bc806c3aaa9f35db2f08801-arm64

it works correctly, which is the opposite of what the Readme says.

Images to Merge => test:ea656058259dade7f6d2f4cd290b45ae74a44ae5-x64, test:ea656058259dade7f6d2f4cd290b45ae74a44ae5-arm64
  Base Images     => test:master
  Amend?          => No
  Push?           => Yes
Creating manifest for image [test:master] with [test:ea656058259dade7f6d2f4cd290b45ae74a44ae5-x64, test:ea656058259dade7f6d2f4cd290b45ae74a44ae5-arm64] outputs
/usr/bin/docker manifest create test:master test:ea656058259dade7f6d2f4cd290b45ae74a44ae5-x64 test:ea656058259dade7f6d2f4cd290b45ae74a44ae5-arm64

Also, there are several references to an outputs input which doesn't exist.

According to the warning from Github Action:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: Noelware/docker-manifest-action@master. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

I noticed that docker manifest push had --amend added at some point in #131, but the push command doesn't take an --amend argument.

/usr/bin/docker manifest push --amend 099538280162.dkr.ecr.eu-west-2.amazonaws.com/iea/shared/cr/gh/bld/psh/test:35f67dba96f940d87fd634a849cc2376b2a5cdc0
unknown flag: --amend
See 'docker manifest push --help'.

Awesomely useful action!

Please create a new release tag with #98.

Hey,
when executing the action, the job fails with error

Error: Error: Module "perf_hooks" was not found. Did you install it?

I noticed this problem first today when my cron based job (once a week) ran.

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

This repository currently has no open or pending branches.

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

Hello, thank you for developing this great action.

v0.3.0 has been released, but applying this release without updating with will result in an error.
The job log where this is occurring is following: https://github.com/tomacheese/my-pixiv/actions/runs/4021878692/jobs/6911501009

Deprecations rather than Removed, so I assumed these would work with the update applied without any changes.
Is this behavior expected?

P.S. I have read the action.yml and I don't know why this error occurs even though required: false is specified.
Well, I am concerned that required: true is specified in src/input.ts.

Also, if possible, when configured deprecated inputs, please mention this in the deprecationMessage, so that appropriate warnings are displayed and easily noticed.

https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#inputsinput_iddeprecationmessage

I look forward to your reply.

It would be nice to be able to set multiple outputs for the base-image.

An example use-case would be tagging a final image as both latest and <sha hash>.

Something along the lines of:

      - name: Create and push manifest images
        uses: Noelware/[email protected]
        with:
          base-image: makeshift27015/nginx-alpine-amplify:b76a0d5602f583fb28d44d076c37818c9fdcc11d,makeshift27015/nginx-alpine-amplify:master,makeshift27015/nginx-alpine-amplify:latest
          extra-images: ${{ needs.vars.outputs.image_list }}
          push: true

My current workaround is to use regctl to retag after creating the manifest with your action (which is awesome, by the way!):

      - name: Retag
        run: |
          curl -sL https://github.com/regclient/regclient/releases/latest/download/regctl-linux-amd64 >regctl
          chmod 755 regctl
          tags="${{ needs.vars.outputs.final_image_tags }}"
          IFS=",";for line in $tags; do
            echo "Retagging ${{ needs.vars.outputs.final_image_name }} to ${line}"
            ./regctl image copy ${{ needs.vars.outputs.final_image_name }} ${line}
          done

Hello.
Thank you for your workaround with docker containers merging with manifest.

Lately it start fail when trying to create manifest. Example output can be found here: https://github.com/PurpleI2P/i2pd/actions/runs/4001302421/jobs/6867928655

/usr/bin/docker manifest create --amend purplei2p/i2pd:latest purplei2p/i2pd:latest-amd64 purplei2p/i2pd:latest-i386 purplei2p/i2pd:latest-arm64 purplei2p/i2pd:latest-armv7
docker.io/purplei2p/i2pd:latest-amd64 is a manifest list

How can we fix this?

The last release is too old https://github.com/Noelware/docker-manifest-action/releases/tag/0.3.1
Could you please make a fresh one?
@auguwu ^

Thanks for this useful action. I use cosign to sign manifests by tag, but it's recommended to use the digest too eg tag@digest. Could the manifest digest be added as an action output?