CCCs are not being executed about i3c-slave-design

[pkimelman-nxp]

It looks like I have a merge error in i3c_ccc_slave.v. I will need to update. The logic should look like:
// the ccc_mask is used to stop unhandled CCCs from being send to
// app
generate if (ID_AS_REGS[`IDREGS_CCCMSK_b]) begin : ccc_unhandled
wire base_msk = cf_CccMask[0] & (idata_byte[6:0]<=8'h1F);
wire basebx_msk = cf_CccMask[1] & (idata_byte>=8'h20) & (idata_byte<=8'h48);
wire basedx_msk = cf_CccMask[2] & (idata_byte>=8'hA0) & (idata_byte<=8'hBF);
wire metb_msk = cf_CccMask[3] & (idata_byte>=8'h49) & (idata_byte<=8'h64);
wire metd_msk = cf_CccMask[4] & (idata_byte>=8'hC0) & (idata_byte<=8'hE3);
wire vendb_msk = cf_CccMask[5] & (idata_byte>=8'h65) & (idata_byte<=8'h7F);
wire vendd_msk = cf_CccMask[6] & (idata_byte>=8'hE4) & (idata_byte<=8'hFF);
assign ccc_uh_mask = base_msk | basebx_msk | basedx_msk |
metb_msk | metd_msk | vendb_msk | vendd_msk;
end else begin
assign ccc_uh_mask = 1'b1;
end endgenerate

[pkimelman-nxp]

I have updated the zip and unzipped copy. This was a merge error. Also, SlvNack updated to not impact 7E (which violates the spec) but still NACKs directed CCCs.

[sdolezal]

ok, great - GETPID is now working with the patched slave. RSTDAA still isn't. It gets ACKed by the slave but no changes of "is_i3c" in engine or "dyn_addr", "i3c_addr" or "dyn_addr_chg" in daa. I'll take a closer look tomorrow - thanks so far!

[pkimelman-nxp]

Note that RSTDAA as a directed CCC has been deprecated. We only use RSTDAA as a broadcast. A master should only use SETNEWDA if it wants to change the DA of a slave.

[sdolezal]

Yes, RSTDAA as broadcast and SETNEWDA both work like intended - Thank you very much!