ocharles / digestive-functors-aeson

Run digestive-functors against a JSON document

digestive-functors-aeson

Run digestive-functors forms against JSON documents (via aeson).

digestive-functors-aeson's Issues

Integer 1 end up as Number 1.0, causing trouble

The code:

data Item =
    { itemComment :: Data.Text.Text
    , itemAmount :: Int }

itemForm :: Form Data.Text.Text IO Item
itemForm = Item
    <$> "commment" .: text Nothing
    <*> "amount" .: stringRead "amount must be integer" Nothing

createItem :: String -> IO String
createItem input = case Attoparsec.maybeResult . Attoparsec.parse Aeson.json . pack $ input of
    Just parsedJson -> do
        print parsedJson
    (view, result) <- digestJSON Forms.itemForm parsedJson 
    case result of
        Just b -> do 
            db . insert_ $ b
            return "Success"
        Nothing -> return $ "Form error: " ++ (unpack $ encode $ jsonErrors view)
Nothing -> return "Parse error"

JSON input:

{
    "comment":"blasfsdf",
    "amount":1
}

I get following output:

Form error: {"amount":"amount must be integer"}

I checked the contents of parsedJson to be:

Object (fromList [("amount",Number 1.0),("comment",String "bla")])

Am I correct to assume that the 1 in the JSON input turned into Number 1.0 and is henceforth treated as Double, causing the error? How to properly parse and digest integer values with digestive-functors-aeson?

Or do I have a simple error elsewhere? All help is appreciated!

jsonErrors and Type Safety

Hello!

First, thank you very much for this library. I'm incorporating it into my "how do I Servant" repo. (I'm very much a Haskell beginner).

Secondly, I noticed that if I have a value of type View that does not actually have any errors, and apply jsonErrors to that value, it will raise an exception.

I was wondering if there is a minimially-intrusive way to increase the type safety of jsonErrors, and what I can do to help with that effort.

Optional primitives

digestive-functors is created for html forms there is no common way to define optional non-text form (or I can't find it?).
Is there any way to define, for example, optionalBool, optionalInteger in digestive-functors-aeson? If no, consider it as feature request :)

Newbie questions

I'm struggling with validating an incoming JSON (newbie alert!).

1. Is there a typo in this example in the docs? Do we really mean to pass "" as the first argument to digestJSON
2. Is it possible to get a slightly longer code snippet where the Form v m a is being constructed using the record constructor and not the tuple constructor?

Bump aeson to 0.9?

Hi, there have been several updates to aeson. Including better error reporting.
I wonder, could you bump dep ver? Seems no major updates been done.
Check: https://hackage.haskell.org/package/aeson-0.9.0.1/changelog
Cheers,
Viktor.

Bump up lens bound?

Gack, lens keeps on getting updated. Now at 4.11.

Does not build with lens-4.2.

Due to the upper bound in the cabal file.

Bump base to 4.8?

Hi! Have you tried digestive-functors-aeson with base-4.8.0? I wonder if it will work, there been a bit of changes https://hackage.haskell.org/package/base-4.8.0.0/changelog.

Default bool value ignored

> let form = "testBool" .: bool (Just True)
> let mValue = decode "{}" :: Maybe Value
> let Just v = mValue
> (view, result) <- digestJSON form v
> result
Just False

The result should be Just True.