Comments (14)
How to detect the default platform ? Can we read this from the OF_path ?
from pgelectron.
this should be in settings.json -- it seems like as we do releases, like ios / osx we 'd need to change this file.
from pgelectron.
ok, thanks :)
But what about the github master version? settings.json
doesn't come with the repo and is auto-generated by index.js
. This could be problematic.
from pgelectron.
settings.json should not be auto generated and should come with the repo, that's how it was before
from pgelectron.
Ok, but if the file exists it won't auto-generate.
Anyways, same problem: how to set the default target from the github repo ?
Maybe auto-generate isn't that bad and we could set the default target from an OS detection ?
from pgelectron.
no I don't think we can, I think this has to be set by hand as we do releases. this is similar to the xml file that comes the PG now. I don't think it can all be automated yet.
from pgelectron.
I think you partially fixed this in your commits from today, didn't you ?
I can select multiple and not deselect one.
I can make something to select default on startup
from pgelectron.
I guess I meant we should do this kind of approach instead of a multi-select form...
from pgelectron.
Added a getSelectedPlatforms() function which reads the toggle states.
from pgelectron.
Sweet thanks! What I also wasn't sure about it how to hide options (or grey them out) in advanced mode (in advance mode you should only see the default platform highlighted and no toggle-able)
from pgelectron.
This can be simply done by CSS but first I'd like to make sure there's always 1 platform selected.
For the moment none is selected on launch which would be a problem in non-advanced mode.
from pgelectron.
I think we could set that here:
for (i = 0; i < platforms.length; i++) {
if (platforms[i] === defaultPlatform){
; // set some other identifier
} else {
$(".platformSelect").append("<div class='platform'>" + platforms[i] + "</span>");
}
}
from pgelectron.
Not needed, CSS will handle it.
The thing is that the git repo has no defaultPlatform
...
from pgelectron.
yeah we should just use osx in the settings.json and then change it later for releases...
from pgelectron.
Related Issues (20)
- use clearer / less nerdy names for platforms? HOT 2
- open link to ofxaddons instead of showing tooltip HOT 1
- app name is still "Electron" HOT 3
- maybe we only need console when you do something like generate a project, etc HOT 8
- Clean dependencies
- ui bugs at the moment(?) HOT 14
- No addons found
- moniker can be discouraging HOT 12
- add verbose toggle HOT 2
- clean up front (semantic-ui) HOT 2
- open project causes error HOT 5
- Using path in index.js causes error HOT 3
- win32 error HOT 6
- top bar drag HOT 5
- addons list include non addon folders (like obj from makefile system). HOT 3
- javascript error HOT 3
- erratic behaviour of update button HOT 2
- Windows 10: can't select platform HOT 10
- Selecting addon from dropdown with mouse leaves partial text HOT 1
- GUI falsely reporting missing addons for update without project files
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pgelectron.