open-dollar / od-sdk Goto Github PK

There are two remaining tasks to enable our SDK to work seamlessly with HAI on Optimism. Please address the following items, using branch add-optimism-hai

1. src/virtual/virtualAnalyticsData.ts has a call vault721.totalSupply to fetch the total number of vaults. This is incompatible, since HAI does not have a vault721 contract. Will need to research how they are fetching total vaults and implement a switch statement to use the other method when on Optimism.
2. src/geb.ts has a call to check if a user has a proxy. We updated our PROXY_REGISTRY and renamed the function from proxies to getProxy. Update the function getProxyAction to properly call proxyRegistry.proxies when on Optimism.

To test the results, run the app on Optimism from branch optimism-hai. Don't forget to yarn link the sdk and build.

Once this issue is completed, I can update the bot to support HAI, and also deploy a second interface for HAI using our od-app 🎉

Resources:

https://solidity-by-example.org/

Depends on #53

• Swap out the use of oracleRelayer.marketPrice() to get the ODG price, for the actual camelotRelayer we will deploy (depends on open-dollar/od-relayer#33)
• Get the correct price for WSTETH using the chainlink oracle

1. Add documentation explaining how auction events are fetched using the subgraph
2. Add documentation for the fallback subgraph URL (#38 (review))
3. Add documentation for fallback subgraph in the od-app repo as well

• Once implemented, will need to update fetchNitroPools to use multicall again

• also update tokens

Related to #18

Still seeing this error, eg in RETH collateral auction

index.tsx:125 TypeError: Cannot read properties of undefined (reading 'toString')
    at auctions.ts:102:44

Create a function to fetch liquidity details for ODG and OD. This will be used for the stats page

• Fetch pool data from camelot https://docs.camelot.exchange/
• Add addresses for existing pools. Later we will update the address to our own pools
  • a stablecoin pool for OD
  • any token pool for ODG
• Fetch both price and liquidity data

Check that geb.deployProxy() works and update readme

Troubleshooting for repaying issue:

• Check changes related to interfaces for the tax collector
• Check changes to how we call functions in the app
• Check changes to how we are using the SDK in the app

Later

Publish a new SDK with the correct decimals

WSTETH

0x5979d7b546e38e414f7e9822514be443a4800529
https://app.aave.com/reserve-overview/?underlyingAsset=0x5979d7b546e38e414f7e9822514be443a4800529&marketName=proto_arbitrum_v3
Oracle CLSynchronicityPriceAdapterPegToBase: https://arbiscan.io/address/0x945fD405773973d286De54E44649cc0d9e264F78

ARB

0x912ce59144191c1204e64559fe8253a0e49e6548
https://app.aave.com/reserve-overview/?underlyingAsset=0x912ce59144191c1204e64559fe8253a0e49e6548&marketName=proto_arbitrum_v3
Oracle EACAggregatorProxy: https://arbiscan.io/address/0xb2A824043730FE05F3DA2efaFa1CBbe83fa548D6

RETH

0xEC70Dcb4A1EFa46b8F2D97C310C9c4790ba5ffA8
Not on camelot
https://app.aave.com/reserve-overview/?underlyingAsset=0xec70dcb4a1efa46b8f2d97c310c9c4790ba5ffa8&marketName=proto_arbitrum_v3
Oracle CLSynchronicityPriceAdapterPegToBase: https://arbiscan.io/address/0x04c28D6fE897859153eA753f986cc249Bf064f71

CBETH:

Not on camelot

WETH

0x82af49447d8a07e3bd95bd0d56f35241523fbab1
https://app.aave.com/reserve-overview/?underlyingAsset=0x82af49447d8a07e3bd95bd0d56f35241523fbab1&marketName=proto_arbitrum_v3
Oracle EACAggregatorProxy: https://arbiscan.io/address/0x639Fe6ab55C921f74e7fac1ee960C0B6293ba612

settleEvents are not being parsed correctly from the Subgraph

TypeError: Cannot read properties of undefined (reading 'toString')
at auctions.ts:106:44

If the subgraph API call fails with an error, a backup subgraph should be tried.

Eg. Our own hosted subgraph is the primary option. If the request fails, and there is a fallback URL, then we try that one

Depends on #45

Now that we can load data from a single pool, we need to add the ability to pull for multiple pools.

• Rename fetchNitroPoolODGwstETH to fetchNitroPool which is more generic
• The arguments should accept the token symbol (eg. WSTETH), instead of the address of the pool
• Validate that we are fetching all data needed (see both app screenshots below)

Remove the warnings for

Duplicate definition of TransferCollateral (TransferCollateral(address,uint256,address,uint256), TransferCollateral(address,bytes32,uint256,address,uint256))

Description

SDK addresses file needs correct # of decimals

• querySubgraph cannot include an authorization token because this is not one of the allowed headers by the Render-deployed Docker image for our graph node

Part of TVL project open-dollar/od-app#234

Description

• Create the spellbook flow for creating a pool, incentivizing deposits, and making a deposit. Should have dev and user flow

• Part 2 of TVL project open-dollar/od-app#234
• Depends on ODProxy work

Depends on #69

Fetch the total deposit for each token in the lp position, including the USD value

Closed by open-dollar/camelot-user-info#1

starts with d229....

Fetch Nitro Pool data using the SDK
Existing branch: https://github.com/open-dollar/od-sdk/pull/50/files.
For testing purposes please find an existing nitro pool on mainnet for Camelot (there is no camelot testnet).

On branch optimism-hai : Liquidity missing from header (works on optimism, but not arb-sepolia)
On branch optimism-hai : Vault NFT number is wrong
Fix CORS errors when doing sanctions API fetching
Test REACT_APP_WALLET_CONNECT_PROJECT_ID on staging

defi-wonderland/solidity-exporter-action was updated to support node 18 defi-wonderland/solidity-exporter-action#47 (comment)

1. Publish a new ABI package using defi-wonderland/solidity-exporter-action
2. Update the ABI package here.
3. Ensure that app using the SDK can be deployed using node 18
4. Update the SDK in the app and bot

• We are checking whether to route transactions by checking whether this.addressList.GEB_TAX_COLLECTOR !== NULL_ADDRESS however, this is preventing us from merging our optimism-hai branch into dev because this logic isn't valid since arbitrum sepolia now has a non null GEB_TAX_COLLECTOR in the latest SDK deployment

1. expose network in the constructor in proxy-actions
2. use network to route transactions

• Need to update SDK workflow file to publish to npm properly, currently all the publish actions are being skipped

Currently the app is delayed by the speed of the subgraph indexer to show the most current auction data.
if we use both on-chain data (last 5000 blocks) and the subgraph together, we could eliminate the data latency

Depends on #53

Faster alternative to #54

Use Alchemy or another SDK to fetch price data for WSTETH, RETH, and ODG

Part 1 of TVL project open-dollar/od-app#234

• Need to connect to Camelot nitro pools via an interface

Potentially helpful resources:
https://github.com/Zapper-fi/studio/blob/bd5d0f3d851b18c5dcd9c129db24312621042594/src/apps/camelot/arbitrum/camelot.nitro.contract-position-fetcher.ts#L18
https://github.com/lyra-finance/interface/blob/59661df7111ccb838398a47152be13144f73f354/app/src/contracts/typechain/CamelotNitroPool.ts#L51

How can we remove all these console logs from the sdk?

Duplicate definition of ModifyParameters (ModifyParameters(bytes32,uint256), ModifyParameters(bytes32,bytes32,uint256))
Duplicate definition of ModifyParameters (ModifyParameters(bytes32,uint256), ModifyParameters(bytes32,address))
Duplicate definition of ModifyParameters (ModifyParameters(bytes32,bytes32,uint256), ModifyParameters(bytes32,uint256), ModifyParameters(bytes32,address), ModifyParameters(bytes32,uint256,uint256), ModifyParameters(bytes32,uint256,uint256,address))
Duplicate definition of ModifyParameters (ModifyParameters(bytes32,uint256), ModifyParameters(bytes32,address), ModifyParameters(bytes32,bytes32,uint256), ModifyParameters(bytes32,bytes32,address))