owncloud-archive / maps Goto Github PK

Rather than always resetting to your position, the Maps app should save the bounding box you last saw and show that again.

When you want to change to your position, there’s already a button for it.

The CacheManager should be replaced with a CacheMapper like described in the Database Documentation.

It should be possible to set points as favorites. They could be shown with star markers on the map, and this layer could be possible to disable in the sidebar.

Similarly, Contacts addresses could be shown as favorites by default (or at least the addresses of the contacts you set as favorite in the Contacts app).

cc @brantje

Currently the map always starts out in Denver. The app should just cache the last area you viewed and start you off there.

Hi!

Contacts are not displayed, in the Firefox Console i get "TypeError: address is undefined"

While trying to activate the maps app on my OwnCloud instance, I got the following error:
An exception occurred while executing 'CREATE TABLE "oc_maps_locations" ("id" BIGSERIAL DEFAULT NULL, "device_hash" VARCHAR(64) DEFAULT NULL, "lat" VARCHAR(64) DEFAULT NULL, "lng" VARCHAR(64) DEFAULT NULL, "timestamp" VARCHAR(64) DEFAULT NULL, "hdop" VARCHAR(64) DEFAULT NULL, "altitude" VARCHAR(64) DEFAULT NULL, "speed" VARCHAR(64) DEFAULT NULL)': SQLSTATE[42601]: Syntax error: 7 FEHLER: mehrere Vorgabewerte angegeben für Spalte »id« von Tabelle »oc_maps_locations«

Syslog:
Oct 28 17:56:22 schmidl ownCloud[15097]: {core} Invalid OCS content returned for app maps Oct 28 17:56:22 schmidl postgres[15121]: [2-1] 2014-10-28 17:56:22 CET FEHLER: mehrere Vorgabewerte angegeben für Spalte »id« von Tabelle »oc_maps_locations« Oct 28 17:56:22 schmidl postgres[15121]: [2-2] 2014-10-28 17:56:22 CET ANWEISUNG: CREATE TABLE "oc_maps_locations" ("id" BIGSERIAL DEFAULT NULL, "device_hash" VARCHAR(64) DEFAULT NULL, "lat" VARCHAR(64) DEFAULT NULL, "lng" VARCHAR(64) DEFAULT NULL, "timestamp" VARCHAR(64) DEFAULT NULL, "hdop" VARCHAR(64) DEFAULT NULL, "altitude" VARCHAR(64) DEFAULT NULL, "speed" VARCHAR(64) DEFAULT NULL) Oct 28 17:56:22 schmidl ownCloud[15097]: {core} An exception occurred while executing 'CREATE TABLE "oc_maps_locations" ("id" BIGSERIAL DEFAULT NULL, "device_hash" VARCHAR(64) DEFAULT NULL, "lat" VARCHAR(64) DEFAULT NULL, "lng" VARCHAR(64) DEFAULT NULL, "timestamp" VARCHAR(64) DEFAULT NULL, "hdop" VARCHAR(64) DEFAULT NULL, "altitude" VARCHAR(64) DEFAULT NULL, "speed" VARCHAR(64) DEFAULT NULL)':#012#012SQLSTATE[42601]: Syntax error: 7 FEHLER: mehrere Vorgabewerte angegeben für Spalte »id« von Tabelle »oc_maps_locations«

I'm operating on the stable_7 from OwnCloud.

If I search there seems to be a marker placed at possible search results, but I would like the map to automatically pan and zoom to the best guess result, and maybe list a set of other possible results in the side bar.

Thanks!

Hello,

it's my firt try to maps app and when i click on "Contacts" to see my contacts on map the progress bar blocked on 38,46 %.
What can i do to see why and debug this problem ?

Sincerely

Now, it is not clear how an user can enable device tracking.
We might add an ? icon in the 'Location tracking settings' popup.
What do you think @jancborchardt

The search box which is visible at the start should have »Search« as label, not »Start«.

And when clicking the [+] button, not the »Destination« field should appear, but rather the »Start« field. Because the place I just searched is more likely to be my destination.

See Google Maps for reference ;)

From the JS log:

Refused to load the image 'http://otile2.mqcdn.com/tiles/1.0.0/osm/16/34944/19841.png'
because it violates the following Content Security Policy directive: "img-src 'self'".
Refused to load the image 'http://otile1.mqcdn.com/tiles/1.0.0/osm/16/34943/19841.png'
because it violates the following Content Security Policy directive: "img-src 'self'".
Refused to load the image 'http://otile1.mqcdn.com/tiles/1.0.0/osm/16/34944/19840.png'
because it violates the following Content Security Policy directive: "img-src 'self'".

@LukasReschke any idea?

cc @brantje @DJaeger @houqp

As mentioned in #53 (comment), it would be cool to show the profile images from Contacts on the map for the contact display.

cc @v1r0x you up for doing that as well? cc @Henni @DJaeger @brantje

Currently when clicking »Amenity« or »Tourism«, all the layers are shown. This is way too much. Instead we should go the other way around by not showing all but instead only a few:

By default enabled for Amenity should be

• toilets
• drinking_water
• atm
• hospital
• post_office

Tourism:

• attraction
• museum
• viewpoint

For the shops … wow – we really simply need one unified search/filter box (like Google Maps for amenities as well as addresses).

When searching for »Berlin«, I get:

GET apps/maps/search?search=Berlin&bbox=[…] 500 (Internal Server Error)
    mapSearch.getSearchResults script.js line 337
    (anonymous function) script.js line 272

@brantje

The input field suggestions are a bit confusing:

• they don’t show as you type, but only after you press enter. Instead they should show as soon as I stopped typing for 500ms (so as to not fire off too many requests)
• they should stop showing up when I removed the letters

quote from martin:

I would like to give you some suggestions for your map app. It would be nice to have a "location history" feature integrated with owncloud and mobile client ... something like google's latitude for the users who do not like to share their location with the rest of the world inteligence... :-) personaly I am using location history for my monthly business trips accounting. Is this a big effort to create such a feature?

What do you think about an icon from here: http://iconmonstr.com/?s=map

The license seems to be okay: http://iconmonstr.com/license/

You are allowed to ...


Use in both personal and commercial projects with no attribution required.

Use in a website or presentation template or application as part of your design with no attribution required.

Modify in shape, color, size or otherwise manipulate for your needs.

Up to 50 icons embed in a font or regenerate as web font via 3rd party tools.
You are not allowed to ...


The icons may not be sub-licensed, resold, rented, redistributed or detached from a template, application or web page.

The icons may not be included in any online or offline archive or archived downloadable format.

@houqp when using the latest Maps app with the latest ownCloud master, I get a white screen and this PHP error:

PHP Fatal error:  Class 'OCA\\AppFramework\\Core\\API' not found
in /home/jan/owncloud/apps/maps/appinfo/app.php on line 34

Any idea how to fix it @houqp @DeepDiver1975 @LEDfan @brantje?

When typing »Sander« into the search field (and assuming I have your address in ownCloud Contacts) I should get the suggestion »Sander, Somestreet, Somecity, Netherlands«.

This would be a great example of inter-app connection in ownCloud. If you want to see how it’s done, check out the mail app code: https://github.com/owncloud/mail (we do that for the »to« and »cc« fields)

Currently every time you click on »Contacts«, it needs to load completely from scratch. The data should be cached somehow so it doesn’t take as long.

cc @v1r0x @Henni

Hi,

I use an ANDROID off line map (MAPS.ME), which stores my locations of interests in KMZ based files.

1. Would it be possible to import KMZ files, exported from the app, into maps to be displayed?
2. Of course syncing these files would be even more advantageous, however it is much more work and larger effort to implement this feature!

regards, hitam4450

ownCloud offers an app-checker by executing php occ app:check-code maps.

Currently this leads to the following errors. We should fix them as far as possible:

Analysing /home/hendrik/Coding/owncloud/apps/maps/appinfo/app.php
 4 errors
    line   15: OCP\App::addNavigationEntry - Method of deprecated class must not be called
    line   24: OCP\Util::linkToRoute - Method of deprecated class must not be called
    line   28: OCP\Util::imagePath - Method of deprecated class must not be called
    line   32: OC_L10N - Static method of private class must not be called
Analysing /home/hendrik/Coding/owncloud/apps/maps/controller/pagecontroller.php
 3 errors
    line  122: == - is discouraged
    line  226: == - is discouraged
    line  229: != - is discouraged
Analysing /home/hendrik/Coding/owncloud/apps/maps/controller/locationcontroller.php
 3 errors
    line  120: != - is discouraged
    line  121: != - is discouraged
    line  139: == - is discouraged
App is not compliant

Currently Maps gives some errors about not found type icons:

[…]
script.js?v=45360383019c34fc1b722568d8ed4110:960 Type icon not found: gallery
script.js?v=45360383019c34fc1b722568d8ed4110:960 Type icon not found: motel
script.js?v=45360383019c34fc1b722568d8ed4110:960 Type icon not found: museum
script.js?v=45360383019c34fc1b722568d8ed4110:960 Type icon not found: theme_park
script.js?v=45360383019c34fc1b722568d8ed4110:960 Type icon not found: zoo

@brantje @DJaeger

compatible with newer versions oC?

We have a boatload of people interested in creating an open, better maps experience. Now we need to collaborate to make sure it works across systems and not only work in our own small world. We need to make it seamless for people to have their search history, favorite places, routes etc. on all their different devices.

@houqp and @eMerzh want to work on an ownCloud Maps app. We exchanged some ideas already and @houqp pushed a basic prototype the other day.
I’ll oversee the design. As a start it should be very simple, full-content map with no sidebar, search field and any elements slightly transparent over the map. See the new Google Maps or GNOME Maps. Also cc @owncloud/designers

@moonlite is working on GNOME Maps as GSoC student with mentor @zeenix. ownCloud is already in GNOME Online Accounts – Mattias, can you ping Debarshi about integration of Maps with that?

@AndreiDuma and @utkuaydin work on synchronization of KDE’s Marble maps app with ownCloud, their mentor is @Earthwings. Since that seems to include an ownCloud app, we need to collaborate here especially to create a proper »Maps« app and not just a »Marble« app.

Also cc @zimba12 and @Raydiation because they participated in the mailing list thread.

On every app load, I get these messages in the log:

"app":"contacts","message":"Caching contact-thumbnail-local::1::9",
"app":"contacts","message":"Caching contact-thumbnail-local::1::27",
"app":"contacts","message":"Caching contact-thumbnail-local::1::42",
"app":"contacts","message":"Caching contact-thumbnail-local::1::62",
"app":"contacts","message":"Caching contact-thumbnail-local::1::71",
"app":"contacts","message":"Caching contact-thumbnail-local::1::91",
"app":"contacts","message":"Caching contact-thumbnail-local::1::99",
"app":"contacts","message":"Caching contact-thumbnail-local::1::100",
"app":"contacts","message":"Caching contact-thumbnail-local::1::126",
"app":"contacts","message":"Caching contact-thumbnail-local::1::137",
"app":"contacts","message":"Caching contact-thumbnail-local::1::162",
"app":"contacts","message":"Caching contact-thumbnail-local::1::168",
"app":"contacts","message":"Caching contact-thumbnail-local::1::184",
"app":"contacts","message":"Caching contact-thumbnail-local::1::3",

Similar in the JS console of the browser. It kind of spams the error log, so it shouldn’t be there, right @brantje?

Great app :-) I like the options menu to display additional information on the map.
I wonder if it's possible to implement functionality for viewing tracks from the uploaded files. I know there is a GPX viewer app but it doesn’t work with OC7 and it seems that the further development is discontinued. Any how it would be great to view a chosen track and toggle nearby contacts shops etc...
Would it be possible to implement this kind of functionality?

Integrate the maki icons which are already used in this repository.
This reduces requests to external sites and would reduce the list of Content-Security-Policies.

Maybe worth a thought https://mapzen.com/projects/tangram/ (choose the »Traditional« style in the bottom right)

But it’s something way advanced so it’s going in the backlog. :) Just putting it here to remember.

Suggestion:
How about to incorporate maps / website http://www.opensourcemap.org/ into OwnCloud ???

Regards, hitam4450

From #58 (comment):

If the Contacts app is not installed, simply do not show the entry in the sidebar and deactivate the functionality.

It would be cool to have events show up on the map when they have a location set and are in the near future (the next 4 weeks).

@MorrisJobke mentioned that GMaps does this. Would be a great way to inter-connect ownCloud apps! cc @brantje @georgehrke

I have install nodejs on Ubuntu 12.04 and do like what wrote down in README.md
but the app not working and raise error 500
the errorlog is :

{"app":"PHP","message":"Undefined variable: message at \/www\/owncloud\/lib\/public\/util.php#95","level":3,"time":"2014-03-23T11:36:32+00:00"}
{"app":"index","message":"Exception: js file not found: script:js\/vendor\/leaflet\/leaflet formfactor: serverroot:\/www\/owncloud","level":4,"time":"2014-03-23T11:36:32+00:00"}
{"app":"PHP","message":"js file not found: script:js\/vendor\/leaflet\/leaflet formfactor: serverroot:\/www\/owncloud at \/www\/owncloud\/lib\/private\/template\/resourcelocator.php#45","level":3,"time":"2014-03-23T11:36:32+00:00"}

I dont know if make watch is important or not, it print somethings and at last prints Waiting... and nothing happened

Would be great to have a feature to display images which have gps exif data.
And maybe it is possible to collaborate with @oparoz ?

Ok @houqp @eMerzh let’s do this. If you like we can have a call about this soon. :)

• As a start it should be very simple, full-content map
• no fixed sidebar (unlike News or Notes) – but it can appear contextually, e.g. for routing or list of favorites
• Search field and any elements slightly transparent over the map.
• Places directly marked in the map, e.g. favorites or search results

See the new Google Maps or GNOME Maps for inspiration.

Currently it’s not possible to do a simple search. This should be the defaut – only one search box in the top left. Routing is the second step then – look at how Google Maps does it.

@brantje @houqp

Currently the map has the ugly »OpenStreetMap look«. We should style it a bit to make it look nicer, more like what Mapbox has for example.

cc @brantje

Ok... maybe this is way beyond the target of this app, but having your own custom tile server could be a really neat feature as an overlay.

A quick search brought this up:
https://github.com/klokantech/tileserver-php/
which might work for integration.

This would also allow for offline/intranet map-viewing for people with a weak net connection or other reasons why they can't easily use external map tile servers.

Is there an option to display kml or gpx files by uploading it to the files section and starting the maps app?

There is a plug in for leaflet that should allow both file types. See: http://psha.org.ru/b/leaflet-plugins.html

An advanced option would be to allow selecting layers of multiple kml and gpx files to be displayed the same time, but for now a simple show kml from the files app would do.

Thanks!

The icon of maps is almost identical with the icon of pinnit!

regards, hitam4450

So in the week of 3-8 till 9-8 i have a week off, and i decided to spend that time on the maps app.
This issue will contain all the little issues i want todo in that week.
If you have any additions, feel free to submit them.

• Issue #21
• Issue #22

The contacts layer doesn’t work for me because I get an error 500 on one address. Instead of not working at all, that address should simply be skipped. @brantje

When dragging the map, add URL parameters that represent the current map's center (compare with Google Maps).

This can be done somehow with OC.History.pushState but might need tweaking to avoid polluting the history.

Having URL parameters make it possible to quickly share the URL with someone else or simply bookmark it.

Hey @houqp what's the state of this app by the way? Do you need any help?

See http://www.mapillary.com/map

Putting this in the backlog because it’s really really future functionality and we need to get quite some other stuff down first.

Suggestion:

How about to incorporate https://www.openstreetmap.org into OwnCloud ???

Regards, hitam4450

The functionality to add a new device should be removed from the settings.
Instead of displaying the modal window it should be added to the 'My devices' menu.

While running :

phpunit tests/

I get :
PHP Fatal error: require_once(): Failed opening required '/var/www/owncloud/apps/maps/tests/../../../3rdparty/Pimple/Pimple.php' (include_path='.:/usr/share/php:/usr/share/pear') in /var/www/owncloud/apps/maps/tests/autoloader.php on line 12

Please add a small description of what the user can expect from this app.

Thanks.

As @MorrisJobke said, we should best use an existing library for the category icons: https://github.com/lvoogdt/Leaflet.awesome-markers

@brantje