GithubHelp home page GithubHelp logo

Comments (4)

pb-dseifert avatar pb-dseifert commented on May 27, 2024 1

@peterjc @bruc provide a PR and I will merge it and cut a new release

from pbbioconda.

bruc avatar bruc commented on May 27, 2024

In my use case, this issue is not a problem.

I have a large (>10 gbp) genome I want to polish, and in order to parallelize the variant calls, I need to split the merged, sorted BAM file and the genome assembly. The merged, sorted BAM file has a header covering all the contigs in the assembly, but in the split jobs, I only reference a small number of contigs per job. I use the header lines from the big merged, sorted BAM file, and I do get the warning message, and that's fine.

Please do not change the code to make this error. Instead, please provide an option to allow the user to make this an error if they choose to do so. Then, 'pb-dseifert' can achieve the program behavior he or she needs, and my use case still works.

Thanks.

from pbbioconda.

peterjc avatar peterjc commented on May 27, 2024

It is good to have an explicit use-case for why the FASTA file might not match the BAM alignment, but rather a subset of the alignment. [In this case you could likely subset the BAM file, but I can can see it is convenient not to have to]. Here those names in common would have matching lengths in the reference FASTA and the alignment header (and indeed their sequence MD5 would match if that were checked)

i.e. I don't think checking names and lengths for consistency would block @bruc's use case - I think you would still get the same warning as now:

[WARNING] Some reference contigs aligned against are not found in the reference FASTA.  Will process only those contigs supported by the reference FASTA.

from pbbioconda.

armintoepfer avatar armintoepfer commented on May 27, 2024

Closing due to lack of activity.

from pbbioconda.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.