GithubHelp home page GithubHelp logo

pages-themes / modernist Goto Github PK

View Code? Open in Web Editor NEW
136.0 136.0 226.0 94 KB

Modernist is a Jekyll theme for GitHub Pages

Home Page: https://pages-themes.github.io/modernist/

License: Creative Commons Zero v1.0 Universal

Ruby 12.44% HTML 21.78% JavaScript 3.89% Shell 8.61% SCSS 53.28%
github-pages jekyll jekyll-theme

modernist's People

Contributors

benbalter avatar gebeto avatar parkr avatar tekaoh avatar tsusdere avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

modernist's Issues

Correct W3C validation errors in assets/css/style.css

I found the following W3C validation errors in assets/css/style.css:

ERROR; URI: file://localhost/TextArea; line 88: 
        
                                Value Error :  background (nullcolors.html#propdef-background)
        
                                “linear_gradient(#6C7989,#434B55)” is not a “background” value : 
                            
ERROR; URI: file://localhost/TextArea; line 96: 
        
                                Value Error :  background (nullcolors.html#propdef-background)
        
                                “inline-image("checker.png")” is not a “background-color” value : 
                            
ERROR; URI: file://localhost/TextArea; line 123: 
        
                                Value Error :  background (nullcolors.html#propdef-background)
        
                                “linear_gradient(#DDFBFC,#C6EAFA)” is not a “background-color” value : 
                            
ERROR; URI: file://localhost/TextArea; line 161: 
        
                                Value Error :  background (nullcolors.html#propdef-background)
        
                                “linear_gradient(#77B9FB,#3782CD)” is not a “background-color” value : 
                            
ERROR; URI: file://localhost/TextArea; line 210: 
        
                                Value Error :  background (nullcolors.html#propdef-background)
        
                                “linear_gradient(#fafafa,#DEDEDE 700px)” is not a “background-color” value : 
                            

Interested in fixing them? Just clone this repository locally, make the suggested change, and run script/cibuild to confirm it's been fixed. After that, you can submit a pull request to get your change merged. Feel free to drop questions here if you run into any problems.

Coloring?

Is it possible to change the color of the modernist theme just configuring the _config.yml file, and how do I do it if so?

Extra spacing added in nested unordered list

https://github.com/emiliebarnard/github-page-guide/blob/main/index.markdown

There is an extra space on the website view between "Insert images" and "Additional documentation" under Navigation on the website, but not in the GitHub preview.

Screenshot 2023-03-05 at 10 25 48 PM

Code:

# Navigation
* [Create a GitHub repository](#create-a-github-repository)
* [Create a GitHub Pages site](create-a-github-pages-site)
* [README file use and work portfolio content](readme-file-use-and-work-portfolio-content)
     * [Add text documentation](add-text-documentation)
     * [Insert images](insert-images)
* [Additional documentation](additional-documentation)

Workaround fix is by forcing a change to the css, but I imagine this is a common-enough markdown sequence that the main repo should be updated.

Google Analytics Only Works for UA not GA4

I'm using Jekyll Now with jekyll-theme-modernist.
If I put UA code for Google Analytics, it works, but if I put GA4 code, it doesn't.
Does this theme support GA4?
Google is asking everyone to switch to GA4 by 2023.

Accessibility errors found in your template

The user @carlsonsantana validate your site template "https://pages-themes.github.io/modernist/" and found these accessibility errors:

  • Page https://pages-themes.github.io/modernist/:
    • Issue c1e7bf7e-9592-4da7-8d9a-db1094750d23:
      • Type: Error
      • Code: WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail
      • Message: This element has insufficient contrast at this conformance level. Expected a contrast ratio of at least 4.5:1, but text in this element has a contrast ratio of 4.44:1. Recommendation: change background to #6a7787.
      • Selector: html > body > footer > p:nth-child(2) > a
      • Context: <a href="https://github.com/orderedlist">orderedlist</a>
    • Issue f6823833-989a-44d8-a835-8024a4b40148:
      • Type: Error
      • Code: WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail
      • Message: This element has insufficient contrast at this conformance level. Expected a contrast ratio of at least 4.5:1, but text in this element has a contrast ratio of 2.76:1. Recommendation: change background to #4b5868.
      • Selector: html > body > footer > p:nth-child(2)
      • Context: <p>Hosted on GitHub Pages — Theme ...</p>
    • Issue b77224cc-182b-4603-b5c2-6e139588672a:
      • Type: Error
      • Code: WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail
      • Message: This element has insufficient contrast at this conformance level. Expected a contrast ratio of at least 4.5:1, but text in this element has a contrast ratio of 4.44:1. Recommendation: change background to #6a7787.
      • Selector: html > body > footer > p:nth-child(1) > a
      • Context: <a href="https://github.com/pages-themes">pages-themes</a>
    • Issue a8147a62-cac6-48f4-ab18-af9104ac8c47:
      • Type: Error
      • Code: WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail
      • Message: This element has insufficient contrast at this conformance level. Expected a contrast ratio of at least 4.5:1, but text in this element has a contrast ratio of 2.76:1. Recommendation: change background to #4b5868.
      • Selector: html > body > footer > p:nth-child(1)
      • Context: <p>Project maintained by <a href="...</p>
    • Issue a6c2db6d-75e2-49c0-8880-c3cfc0636202:
      • Type: Error
      • Code: WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail
      • Message: This element has insufficient contrast at this conformance level. Expected a contrast ratio of at least 4.5:1, but text in this element has a contrast ratio of 3.02:1. Recommendation: change background to #1d1f25.
      • Selector: html > body > div > section > div:nth-child(11) > div > pre > code > span:nth-child(27)
      • Context: <span class="k">end</span>
    • Issue ab43706d-964f-4409-97ef-251a34efd02a:
      • Type: Error
      • Code: WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail
      • Message: This element has insufficient contrast at this conformance level. Expected a contrast ratio of at least 4.5:1, but text in this element has a contrast ratio of 4.2:1. Recommendation: change background to #35373d.
      • Selector: html > body > div > section > div:nth-child(11) > div > pre > code > span:nth-child(25)
      • Context: <span class="s2">"</span>
    • Issue 078df8b7-842d-4cab-9342-6983ec096528:
      • Type: Error
      • Code: WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail
      • Message: This element has insufficient contrast at this conformance level. Expected a contrast ratio of at least 4.5:1, but text in this element has a contrast ratio of 1.85:1. Recommendation: change text colour to #fffefe.
      • Selector: html > body > div > section > div:nth-child(11) > div > pre > code > span:nth-child(24)
      • Context: <span class="si">}</span>
    • Issue 0906ce6f-5065-46a4-a176-71788793f6a9:
      • Type: Error
      • Code: WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail
      • Message: This element has insufficient contrast at this conformance level. Expected a contrast ratio of at least 4.5:1, but text in this element has a contrast ratio of 1.85:1. Recommendation: change text colour to #fffefe.
      • Selector: html > body > div > section > div:nth-child(11) > div > pre > code > span:nth-child(22)
      • Context: <span class="si">#{</span>
    • Issue b0a728ba-bed2-4646-9582-620d7151e17b:
      • Type: Error
      • Code: WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail
      • Message: This element has insufficient contrast at this conformance level. Expected a contrast ratio of at least 4.5:1, but text in this element has a contrast ratio of 4.2:1. Recommendation: change background to #35373d.
      • Selector: html > body > div > section > div:nth-child(11) > div > pre > code > span:nth-child(21)
      • Context: <span class="s2">"= </span>
    • Issue a478edf9-af4a-4bce-93a4-490bb04fc42f:
      • Type: Error
      • Code: WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail
      • Message: This element has insufficient contrast at this conformance level. Expected a contrast ratio of at least 4.5:1, but text in this element has a contrast ratio of 3.02:1. Recommendation: change background to #1d1f25.
      • Selector: html > body > div > section > div:nth-child(11) > div > pre > code > span:nth-child(9)
      • Context: <span class="k">do</span>
    • Issue fa0f46bb-26e9-44d9-a33d-55b4f850367b:
      • Type: Error
      • Code: WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail
      • Message: This element has insufficient contrast at this conformance level. Expected a contrast ratio of at least 4.5:1, but text in this element has a contrast ratio of 3.11:1. Recommendation: change background to #1f2127.
      • Selector: html > body > div > section > div:nth-child(11) > div > pre > code > span:nth-child(1)
      • Context: <span class="c1"># Ruby code with syntax highlig...</span>
    • Issue 008ec1a0-e4d5-4a72-8a7b-76cd0b2754c5:
      • Type: Error
      • Code: WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail
      • Message: This element has insufficient contrast at this conformance level. Expected a contrast ratio of at least 4.5:1, but text in this element has a contrast ratio of 3.74:1. Recommendation: change background to #2d2f35.
      • Selector: html > body > div > section > div:nth-child(10) > div > pre > code > span:nth-child(22)
      • Context: <span class="kc">true</span>
    • Issue 80e960f2-e617-41a2-b111-97192a5b56a4:
      • Type: Error
      • Code: WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail
      • Message: This element has insufficient contrast at this conformance level. Expected a contrast ratio of at least 4.5:1, but text in this element has a contrast ratio of 3.02:1. Recommendation: change background to #1d1f25.
      • Selector: html > body > div > section > div:nth-child(10) > div > pre > code > span:nth-child(21)
      • Context: <span class="k">return</span>
    • Issue 8de13c73-9224-452a-87a3-ded70ca6da3f:
      • Type: Error
      • Code: WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail
      • Message: This element has insufficient contrast at this conformance level. Expected a contrast ratio of at least 4.5:1, but text in this element has a contrast ratio of 4.2:1. Recommendation: change background to #35373d.
      • Selector: html > body > div > section > div:nth-child(10) > div > pre > code > span:nth-child(17)
      • Context: <span class="s1">'./lang/'</span>
    • Issue c8f5e1ab-a68e-4d98-9f8a-cfeb1959ca9d:
      • Type: Error
      • Code: WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail
      • Message: This element has insufficient contrast at this conformance level. Expected a contrast ratio of at least 4.5:1, but text in this element has a contrast ratio of 3.74:1. Recommendation: change background to #2d2f35.
      • Selector: html > body > div > section > div:nth-child(10) > div > pre > code > span:nth-child(5)
      • Context: <span class="kd">function</span>
    • Issue cd7df44d-45d7-4015-ba6d-cd9fa847c035:
      • Type: Error
      • Code: WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail
      • Message: This element has insufficient contrast at this conformance level. Expected a contrast ratio of at least 4.5:1, but text in this element has a contrast ratio of 3.74:1. Recommendation: change background to #2d2f35.
      • Selector: html > body > div > section > div:nth-child(10) > div > pre > code > span:nth-child(2)
      • Context: <span class="kd">var</span>
    • Issue 8a5ad795-5bb5-4e17-9c29-5ab2c76be362:
      • Type: Error
      • Code: WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail
      • Message: This element has insufficient contrast at this conformance level. Expected a contrast ratio of at least 4.5:1, but text in this element has a contrast ratio of 3.11:1. Recommendation: change background to #1f2127.
      • Selector: html > body > div > section > div:nth-child(10) > div > pre > code > span:nth-child(1)
      • Context: <span class="c1">// Javascript code with syntax ...</span>
    • Issue 7241e267-2c8e-4ea0-925d-733563a4742f:
      • Type: Error
      • Code: WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail
      • Message: This element has insufficient contrast at this conformance level. Expected a contrast ratio of at least 4.5:1, but text in this element has a contrast ratio of 1.32:1. Recommendation: change text colour to #757575.
      • Selector: html > body > div > section > blockquote > p:nth-child(2)
      • Context: <p>When something is important eno...</p>
    • Issue b5bac8b0-780b-4485-948d-b62ac073ec50:
      • Type: Error
      • Code: WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail
      • Message: This element has insufficient contrast at this conformance level. Expected a contrast ratio of at least 4.5:1, but text in this element has a contrast ratio of 1.32:1. Recommendation: change text colour to #757575.
      • Selector: html > body > div > section > blockquote > p:nth-child(1)
      • Context: <p>This is a blockquote following ...</p>
    • Issue 16ea8921-2f62-4d0f-b8c7-683712582d85:
      • Type: Error
      • Code: WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail
      • Message: This element has insufficient contrast at this conformance level. Expected a contrast ratio of at least 4.5:1, but text in this element has a contrast ratio of 3.66:1. Recommendation: change text colour to #52687c.
      • Selector: html > body > div > header > p:nth-child(2)
      • Context: <p>Modernist is a theme for GitHub...</p>

You can check these accessibility errors using pa11y.
You can view the full validation results in our website.

Code blocks don't use an inclusive font stack

I'm using openSUSE, which doesn't have any of the fonts that are used in the stack (Monaco, Bitstream Vera Sans Mono, Lucida Console, Terminal) preinstalled. This leads to it using the default font set in the browser.

Here's how it looks (it's rendering FiraGO, my set default font):

image

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.