phdata / sdc-api-tool Goto Github PK

There should be no dashes in module name

Travis might be good and is free for open source projects. This could be a template: https://github.com/AndreLouisCaron/pytest-docker/blob/master/.travis.yml. This example also uses coveralls for reporting

http://docs.python-requests.org/en/master/user/advanced/#ssl-cert-verification

There's the python file and script that use 'util'

using the long flag format --command-here all lowercase and dashes separating words

sdc-tool pipeline delete --pipelineId ...

verb DELETE to /vi/pipeline/{pipelineid}

Check return values for import/export start/stop etc

When executing

--dest=dev \
--pipelineJson ss-producer.json \
--pipelineId <pipeline-id> \
--overwrite

The tool should first check to see if that pipeline is already in a state of RUNNING before trying to import. Otherwise, the import process will fail.

I'm not huge on a lot of unit tests for an application like this because it doesn't have a lot of branching and most of the work it does is with an external tool. Mocking is mostly a waste when dealing with an external api so Docker seems the good choice for most testing. The current docker 'test' is just a temporary hack, tests written in python that do real assertion and container cleanup are needed.

I think the root init.py could/should be removed. I don't believe it serves a purpose now that the code is inside the src/sdc-tool subdirectory.

Can be enabled as part of travis build

I'm going to throw out 'streamliner'

https://www.pylint.org/