plasmodic / ecto_ros Goto Github PK

View Code? Open in Web Editor NEW

1.0 1.0 10.0 771 KB

Python 19.88% C++ 71.16% Shell 0.03% CMake 8.93%

ecto_ros's People

Contributors

Stargazers

Watchers

Forkers

v4hn jon-weisz stonier jihoonl drmateo yujinrobot samiamlabs y-mj buckmole fujiehuang

ecto_ros's Issues

installing wrong CMake config file

The custom logic (

ecto_ros/cmake/CMakeLists.txt

Line 9 in 7e9d33c

 install(DIRECTORY ${CATKIN_DEVEL_PREFIX}/${CATKIN_PACKAGE_SHARE_DESTINATION}/cmake 

) installs the generated CMake config file for the devel space. This overwrites the CMake config file specifically generated for the install space.

An example of a failing job: http://54.183.26.131:8080/job/Ibin_arm_uThf__object_recognition_ros__ubuntu_trusty_armhf__binary/3/consoleFull#console-section-11

Bagging

This would seem to have issues:

ecto subscribers block, meaning that the bagging will occur at the rate of the slowest subscriber - non-blocking subscribers could potentially help.
the ecto loop itself introduces latency to the bagging since it's a single thread.

The former is probably tractable (#4), but the latter is probably not. We're currently looking at just bagging externally.

Build failure on Ubunut 18.04

I'm trying to build ecto for ROS Melodic on Ubuntu 18.04. ecto and ecto_pcl were built but this package fails when:
catkin build --this -j 4 -v

with this error:

[  0%] Built target actionlib_msgs_generate_messages_lisp
/usr/bin/make -f src/CMakeFiles/ecto_std_msgs_ectomodule.dir/build.make src/CMakeFiles/ecto_std_msgs_ectomodule.dir/depend
/usr/bin/make -f src/CMakeFiles/ecto_geometry_msgs_ectomodule.dir/build.make src/CMakeFiles/ecto_geometry_msgs_ectomodule.dir/depend
/usr/bin/make -f src/CMakeFiles/ecto_sensor_msgs_ectomodule.dir/build.make src/CMakeFiles/ecto_sensor_msgs_ectomodule.dir/depend
make[2]: Entering directory '/home/elod/work/ws_robfun/build/ecto_ros'
cd /home/elod/work/ws_robfun/build/ecto_ros && /usr/bin/cmake -E cmake_depends "Unix Makefiles" /home/elod/work/ws_robfun/src/ecto_ros /home/elod/work/ws_robfun/src/ecto_ros/src /home/elod/work/ws_robfun/build/ecto_ros /home/elod/work/ws_robfun/build/ecto_ros/src /home/elod/work/ws_robfun/build/ecto_ros/src/CMakeFiles/ecto_std_msgs_ectomodule.dir/DependInfo.cmake --color=
make[2]: Entering directory '/home/elod/work/ws_robfun/build/ecto_ros'
cd /home/elod/work/ws_robfun/build/ecto_ros && /usr/bin/cmake -E cmake_depends "Unix Makefiles" /home/elod/work/ws_robfun/src/ecto_ros /home/elod/work/ws_robfun/src/ecto_ros/src /home/elod/work/ws_robfun/build/ecto_ros /home/elod/work/ws_robfun/build/ecto_ros/src /home/elod/work/ws_robfun/build/ecto_ros/src/CMakeFiles/ecto_geometry_msgs_ectomodule.dir/DependInfo.cmake --color=
make[2]: Entering directory '/home/elod/work/ws_robfun/build/ecto_ros'
cd /home/elod/work/ws_robfun/build/ecto_ros && /usr/bin/cmake -E cmake_depends "Unix Makefiles" /home/elod/work/ws_robfun/src/ecto_ros /home/elod/work/ws_robfun/src/ecto_ros/src /home/elod/work/ws_robfun/build/ecto_ros /home/elod/work/ws_robfun/build/ecto_ros/src /home/elod/work/ws_robfun/build/ecto_ros/src/CMakeFiles/ecto_sensor_msgs_ectomodule.dir/DependInfo.cmake --color=
make[2]: Leaving directory '/home/elod/work/ws_robfun/build/ecto_ros'
make[2]: Leaving directory '/home/elod/work/ws_robfun/build/ecto_ros'
/usr/bin/make -f src/CMakeFiles/ecto_std_msgs_ectomodule.dir/build.make src/CMakeFiles/ecto_std_msgs_ectomodule.dir/build
/usr/bin/make -f src/CMakeFiles/ecto_geometry_msgs_ectomodule.dir/build.make src/CMakeFiles/ecto_geometry_msgs_ectomodule.dir/build
make[2]: Entering directory '/home/elod/work/ws_robfun/build/ecto_ros'
make[2]: Nothing to be done for 'src/CMakeFiles/ecto_ros_main_ectomodule.dir/build'.
make[2]: Leaving directory '/home/elod/work/ws_robfun/build/ecto_ros'
make[2]: Entering directory '/home/elod/work/ws_robfun/build/ecto_ros'
make[2]: Leaving directory '/home/elod/work/ws_robfun/build/ecto_ros'
make[2]: *** No rule to make target 'src/CMakeFiles/ecto_std_msgs_ectomodule.dir/build'.  Stop.
CMakeFiles/Makefile2:2004: recipe for target 'src/CMakeFiles/ecto_std_msgs_ectomodule.dir/all' failed
make[1]: *** [src/CMakeFiles/ecto_std_msgs_ectomodule.dir/all] Error 2
make[2]: *** No rule to make target 'src/CMakeFiles/ecto_geometry_msgs_ectomodule.dir/build'.  Stop.
make[2]: Entering directory '/home/elod/work/ws_robfun/build/ecto_ros'
make[2]: Leaving directory '/home/elod/work/ws_robfun/build/ecto_ros'
CMakeFiles/Makefile2:2122: recipe for target 'src/CMakeFiles/ecto_geometry_msgs_ectomodule.dir/all' failed
make[1]: *** Waiting for unfinished jobs....
make[1]: *** [src/CMakeFiles/ecto_geometry_msgs_ectomodule.dir/all] Error 2
make[2]: Leaving directory '/home/elod/work/ws_robfun/build/ecto_ros'
/usr/bin/make -f src/CMakeFiles/ecto_sensor_msgs_ectomodule.dir/build.make src/CMakeFiles/ecto_sensor_msgs_ectomodule.dir/build
make[2]: Entering directory '/home/elod/work/ws_robfun/build/ecto_ros'
make[2]: Leaving directory '/home/elod/work/ws_robfun/build/ecto_ros'
make[2]: *** No rule to make target 'src/CMakeFiles/ecto_sensor_msgs_ectomodule.dir/build'.  Stop.
make[1]: *** [src/CMakeFiles/ecto_sensor_msgs_ectomodule.dir/all] Error 2
CMakeFiles/Makefile2:2203: recipe for target 'src/CMakeFiles/ecto_sensor_msgs_ectomodule.dir/all' failed
[100%] Built target ecto_ros_main_ectomodule
make[1]: Leaving directory '/home/elod/work/ws_robfun/build/ecto_ros'
Makefile:140: recipe for target 'all' failed

Did I miss to install a dependency for ecto_geometry_msgs_ectomodule?

Synchronizer::process returns OK even if some outputs are not valid yet

The detection app is segfaulting intermittently when run on outputs from gazebo. I believe this is because commit 90352ef allowed the process method of subscribers to return even without a valid message in their queue, and the synchronizer ignores the DO_OVER result.

Blocking subscribers

Subscribers by default are setup to block and pop messages one at a time. This is causing issues if we wish to subscribe to two topics at different rates. Essentially the ecto loop is forced to run as slow as the slower topic, which results in messages getting lost in the faster topic.

A non-blocking subscriber could help - experimenting with one here.

Commit/revert

@vrabaud

Accidentally got my git push pointer confused between my remote and this one. End result, I pushed two fixes directly here.

I've reverted these, but they are filling up the history needlessly now. Do you want to reset back to the hash prior to these two commits or shall I just make pull requests for these two fixes on top of these reverts?

Apologies 😕

How to access ecto_ros libs from c++?

These are bundled in the ectomodule and installed to the python directories.

If another cell wanted to make use of these (in it's c++ code), how does it find these shared libraries? Example code:

typedef ecto_ros::Subscriber<sensor_msgs::Image> ImageSubscriber;
left_image_subscriber = ecto::cell::ptr(new ecto::cell_<ImageSubscriber>);

ros_comm fix not yet released

Hey Vincent,

didn't read you in like three days... :-D
I just tripped over the following error using the ubuntu modules:

$ rospack deps-manifests ecto_ros
[rospack] Error: package/stack 'ecto_ros' depends on non-existent package 'ros_comm' and rosdep claims that it is not a system dependency. Check the ROS_PACKAGE_PATH or try calling 'rosdep update'

You fixed this problem a year ago via 73920f1
but didn't push a new release since then.

Would be great if you could push a new release.

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.

Jobs

Jooble