probonopd / timelord Goto Github PK

Hi, thanks for the Arduio library. I have a few PRs I would like to raise and wondered if you would tag this repo for Hacktoberfest 2011. Info available here:

A repository/project is considered to be participating in Hacktoberfest if the 'hacktoberfest' topic is present and is accepting public contributions via pull requests. An individual pull request can also be opted-in directly by adding the 'hacktoberfest-accepted' label.

A pull request is considered approved once it has an overall approving review from maintainers, or has been merged by maintainers, or has been given the 'hacktoberfest-accepted' label. A pull request with any label containing the word 'spam' or 'invalid' will be considered ineligible for Hacktoberfest.

Hacktoberfest 2021

Can you please explain to me how i can get in serial monitor the moon phase at a certain date?
Thank you.

In the SunriseSunset.ino code is the line:

byte today[] = { 0, 0, 12, 27, 10, 2012 }; // store today's date (at noon) in an array for TimeLord to use

How is it possible to get a number (2012 here) in a BYTE!!

I think the correct line should read:

byte today[] = { 0, 0, 12, 27, 10, 12 }; // store today's date (at noon) in an array for TimeLord to use

for in the cpp file always 2000 is added to the year