GitHub Job interface made into or complemented with a class that has helpers to aid building a job about projen

[mrgrain]

I'm not sure I remember the exact situation. If you can help me recall what issues this is attempting to resolve and how, I can be of more assistance to you.

[dkershner6]

Basically, workflow jobs get pretty readonly at the moment, fairly closed to modification. You recommended they should become a class to alleviate this at the same time as you recommended that TaskWorkflowJob become a class (which that class now extends the new one).

As an outside user making constructs, adding an env variable to a job looks like this:

const job: Job;
const updatedJob = {
...job,
env: {
...job.env,
newEnv: newValue
}}
workflow.updateJob("jobName", updatedJob);

I propose:

const job: Job;
job.addEnv("newEnv", newValue);

The perfect naming and way to achieve this escapes me, but I think the idea is quite sound and well paved in other parts of projen.

[dkershner6]

Ping @mrgrain for feedback because I must always be bothering you with at least 1 thing.

[mrgrain]

Thanks @dkershner6 I'm happy to move ahead with this. It will be relatively low priority on my end, so I'd also recommend you to look for experienced peers to provide reviews to make the cycles quicker.

And please make sure you write some docs around this as part of the PR.

[dkershner6]

Thanks @dkershner6 I'm happy to move ahead with this. It will be relatively low priority on my end, so I'd also recommend you to look for experienced peers to provide reviews to make the cycles quicker.

And please make sure you write some docs around this as part of the PR.

Appreciate the feedback, Momo. I will think about this some more versus adding more preSteps and postSteps. Really, I just don't like violating readonly access, but that is our current course of action, which works as well.