promise-nuggets / promise-nuggets.github.io Goto Github PK

https://github.com/promise-nuggets/promise-nuggets.github.io/blob/src/src/documents/articles/15-map-in-series.html.md

var current = Promise.fulfilled();

Promise.fulfilled() seems to be undocumented. I think it might be the same as Promise.resolve()

Unrelated Suggestion:
In the notes, or as a comment, point out that getItem( id ) returns a promise (especially unresolved, unlike the first in the chain), otherwise it looks to newbs like me that there's no async magic happening anywhere in this example. (I think I have this figured out)

Update mapLimit not to rely on bluebird, but only mention the bluebird option like in "Wrapping callback functions".

Update "Doing things in parallel" to use the now general Promise.all

Update "Complex task dependencies" to use destructuring and only recommend spread/join as a bluebird alternative.

https://github.com/promise-nuggets/promise-nuggets.github.io/blob/src/src/documents/articles/12-doing-things-in-series.html.md

The callback is called with no error and an array of results after all operations are complete, or when the first error is encountered.

I believe the callback of waterfall gets the last task's result rather than an array of results(that's what series's callback gets).
Will make a PR for it.

"And that operation is represanted with a promise." should be "And that operation is represented with a promise." at https://github.com/promise-nuggets/promise-nuggets.github.io/blob/master/articles/01-the-simplest-example.html#L20