prontolabs / pronto-reek Goto Github PK
View Code? Open in Web Editor NEWPronto runner for Reek, code smell detector for Ruby
License: MIT License
Pronto runner for Reek, code smell detector for Ruby
License: MIT License
Hi,
How about releasing the 0.11.1 release since no PR got there?
I love running reek with the -U flag to give links to the documentation related to the smell.
Is there some way to pass these flags through pronto-reek to pronto to adjust the reek output?
I can't update any pronto plugin without updating all of them. Thanks.
pronto run
does not use the .reek configuration file in the project directory. When reek is used directly it does use the config. How can I tell pronto-reek to use the reek config?
I'm experimenting with using reek as part of our CI process however I'm noticing that reek seems to always return 0 (success) even though it logs a number of issues.
Is this the expected behaviour, and if so, can it be overridden?
Currently, pronto-reek will still check and comment on files that are in exclude_paths
in your reek configuration. It seems like pronto-reek should be somehow setting the force_exclusion option to true as introduced in troessner/reek#1200 .
I'll introduce a PR if I have time!
It works fine on v2.0.1 but breaks on v2.0.2 with the following error:
/Users/jeroen/.gem/ruby/2.2.0/gems/reek-2.0.2/lib/reek/core/smell_repository.rb:22:in `initialize': uninitialized constant Reek::Core::SmellRepository::Configuration (NameError)
I don't know exactly what causes the issues, but it appears that some related code might have changed: troessner/reek@v2.0.1...v2.0.2. I'll try to have a deeper look at it when I find some time.
Given I have the code on GH (path/some_class.rb
)
class SomeClass
def do_stuff
One.new
Two.new
Three.new
Four.new
Five.new
end
end
The current reek status is:
Inspecting 1 file(s):
.
I change the file and create a pull request that changes the file like follows
class SomeClass
def do_stuff
One.new
Two.new
Three.new
Four.new
Five.new
Six.new
end
end
Inspecting 1 file(s):
S
/path/pronto_reek.rb -- 1 warning:
[2]:TooManyStatements: SomeClass#do_stuff has approx 6 statements [https://github.com/troessner/reek/blob/master/docs/Too-Many-Statements.md]
Pronto rubocop will not create any comment on my PR, because the report is on
the method on line 2, which is not part of the changed code.
Now, if I add a comment in the line of the method name (where reek reports the
violaiton) and update the PR, I will get a comment from pronto, because line num 2 changed.
class SomeClass
def do_stuff # now it reports
One.new
Two.new
Three.new
Four.new
Five.new
Six.new
end
end
It is a bug, isn't it? The new code created a violation in the existing code.
reek is currently on 3.3.0 - is there any way to have pronto-reek use this @mmozuras ?
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.