Rhodes Example: TypeError: can't convert expression to float about pyphs

[afalaize]

Hello @ntonnaett! Thank you for contibuting!

Yes, we are in a big mess here. The error occurs at c++ code generation, more preciely at generation of the array associated with the parameters contained in method.subs inherited from core.subs in
File "/home/nils/Development/pyphs/pyphs/numerics/cpp/method2cpp.py", line 331, in _append_subs

The problem is that the parameter with symbol Pickupf is an expression, not a numerical value:

>>> core.subs[core.symbols('Pickupf')]
1/(2*Pickup_Rb**2*Pickup_Rp*dtq_PickupOBS*((-Pickup_Lh**2 + (Pickup_Lv - Pickup_Rp + q_PickupOBS)**2)/(Pickup_Lh**2 + (Pickup_Lv - Pickup_Rp + q_PickupOBS)**2)**2 - (-Pickup_Lh**2 + (Pickup_Lv + Pickup_Rp + q_PickupOBS)**2)/(Pickup_Lh**2 + (Pickup_Lv + Pickup_Rp + q_PickupOBS)**2)**2))

At this point, it should have been substituted everywhere in method before entering the cpp code generation module, with a call to the core method substitute(selfexprs=True) (from the core or the method). At least, this was the case in pyphs 0.3 (current master which is broken due to dependencies).

I'll have a look as soon as possible

[afalaize]

solved by PR #130