C++ code feature: CMakeLists.txt template about pyphs

[WetzelVictor]

Someone also answered on my StackOverflow question

The cxx_std_11 compiler meta-feature is not available in your version of CMake. it was introduced in 3.8, so this would explain the error, CMake 3.8 release notes.

So either the CMakeLists.txt should request a higher Cmake version (3.8 which is not delivered directly in stock Ubuntu 16.04 LTS distros for instance), or we retrograde to the mentionned commit in order to have backward compatibility with older versions of Cmake..

[afalaize]

Thank you.
This is a retrograde change compared to this commit. I have not a clear idea on the rational underlying this change. I will ask the author to clarify.

[FabricioS]

Thanks Antoine for the quick answer.
FYI, Eigen is C++98 compliant. Moreover, it is a header only library, it is theoretically not concerned by the way the standard is set.

[afalaize]

Yes. The need for cxx1 spec is related to the use of "dynamic initialization" of eigen matrices in the c++ code generated by PyPHS (see here). This is somehow related to this stack overflow answer. This is a choice of implementation which, as everything in PyPHS, is not a definitive choice. Any proposal on this point is welcome.
I will consider the merge of PR #100 this week-end.

[FabricioS]

Thanks Antoine for considering the pull request.
There is no trouble per se with the use of C++11 standard, just with the way to specify it to cmake (and to the compiler) or to ensure cmake has the requested feature.

The remaining question is whether there was a rationale for Remy to suggest that modification in his commit

[WetzelVictor]

Issue solved with PR #101 and #104

[afalaize]

We will close this issue when passed into master branch