GithubHelp home page GithubHelp logo

Comments (1)

cwrowley avatar cwrowley commented on June 20, 2024

Good catch--thanks @callawaycass

Now that you pointed this out, it seems inconsistent for this routine to take phase inputs in degrees, while sys.freqresp(omega) returns phases in radians. For instance, one might expect the following code to work:

sys = TransferFunction(1,[1,1])
mag, phase, omega = sys.freqresp(np.logspace(-1,1,100))
margins = stability_margins((mag,phase,omega))

but the units of phase are wrong. So I wonder if we should change freqresp to return phase in degrees, in order to be more consistent? I notice the docstring for freqresp doesn't specify the units of phase either, so regardless of whether we change the routine, we should improve the documentation.

from python-control.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.