GithubHelp home page GithubHelp logo

Comments (3)

sawyerbfuller avatar sawyerbfuller commented on July 20, 2024

Hi John great to hear from you and happy holidays. Glad to see you are using or at the very least evaluating the library.

The matched c2d is code I have never used before and it doesnโ€™t look like we have a unit test for it, so there is a decent chance it is just a bug. Thanks for the report!

One q - when you refer to gain, do you mean the DC gain of the two systems?

from python-control.

murrayrm avatar murrayrm commented on July 20, 2024

I did a quick check and I agree there is something wrong in the matched transformation:

import control as ct
sysc = ct.tf([1, 2], [1, 3], name='sysc')
sysd_bilinear = ct.sample_system(sysc, 0.1, method='bilinear', name='sysd_bilinear')
sysd_matched = ct.sample_system(sysc, 0.1, method='matched', name='sysd_matched')
ct.bode([sysd_bilinear, sysd_matched, sysc])

This produces the following plot:
Figure_1

A couple of things to fix:

  • Zero frequency gain for the 'matched' transformation is incorrect.
  • The name of the system is lost when doing the 'matched' transformation.
  • The order of the system names is incorrect in the figure title

from python-control.

murrayrm avatar murrayrm commented on July 20, 2024

Fixed in #951. New plot:

Figure_2

from python-control.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.