rchiossi / dexterity Goto Github PK

I would like to point out that identifiers like "__DEX__" and "_ByteStream" do not fit to the expected naming convention of the C language standard.
Would you like to adjust your selection for unique names?

gcc version 4.2.1 (Based on Apple Inc. build 5658) (LLVM build 2336.11.00)
12.2.1 Darwin Kernel Version 12.2.1:

When I try run make on my OSX box I get the following errors:

$ make
make -C lib
gcc -fPIC -std=gnu99 -g -c bytestream.c
bytestream.c:2:20: error: malloc.h: No such file or directory
bytestream.c: In function ‘bsalloc’:
bytestream.c:16: warning: implicit declaration of function ‘printf’
bytestream.c:16: warning: incompatible implicit declaration of built-in function ‘printf’
bytestream.c:27: error: ‘MAP_ANONYMOUS’ undeclared (first use in this function)
bytestream.c:27: error: (Each undeclared identifier is reported only once
bytestream.c:27: error: for each function it appears in.)
bytestream.c:31: warning: incompatible implicit declaration of built-in function ‘printf’
bytestream.c: In function ‘bsmap’:
bytestream.c:46: warning: incompatible implicit declaration of built-in function ‘printf’
bytestream.c:52: warning: incompatible implicit declaration of built-in function ‘printf’
bytestream.c:60: warning: incompatible implicit declaration of built-in function ‘printf’
bytestream.c:76: warning: incompatible implicit declaration of built-in function ‘printf’
bytestream.c: In function ‘bssave’:
bytestream.c:250: error: ‘FILE’ undeclared (first use in this function)
bytestream.c:250: error: ‘f’ undeclared (first use in this function)
bytestream.c:250: warning: implicit declaration of function ‘fopen’
bytestream.c:254: warning: implicit declaration of function ‘fwrite’
bytestream.c:254: warning: incompatible implicit declaration of built-in function ‘fwrite’
bytestream.c:256: warning: implicit declaration of function ‘fflush’
bytestream.c:257: warning: implicit declaration of function ‘fclose’
make[1]: *** [bytestream] Error 1
make: *** [build_lib] Error 2

The metadata field types are swapped. offset is defined as c_bool and corrupted as c_uint.

I suggest to add the key word "const" to the type specifiers for parameters like "filename" (functions "bsmap" and "dx_build").
Would you like to apply the advices from an article to more places in your source files?

I know it's been a while since this project has been touched but while it's being a side result of the code: Is it possible to get something like a usage example or API documentation on libdexterity?

I was looking for a Dex-Parser in C and it was the closest I got, but I am having a hard time trying to use the lib for a project.

Thanks in advance!