reactioncommerce / api-plugin-carts Goto Github PK

Prerequisites

• [ + ] Are you running the latest version?
• [ + ] Are you able to consistently reproduce the issue?
• [ + ] Did you search the issue queue for existing issue? Search issues

Issue Description

Currently every time the cart gets updated (add item, remove item, set shipping address etc) the transformAndValidateCart method is being called, which in turn calls updateCartFulfillmentGroups.
This works well when there is no need to build custom fulfillment groups or allow customer to place cart items in specific groups.
This is because updateCartFulfillmentGroups is destructive, it will iterate over each cart item to determine the group it should belong to based on the supported shipping type. The item ends up being re-allocated even if it was previously assigned to a specific group by the customer or some other underlying mechanism.

Possible Solution

In updateCartFulfillmentGroups determine if the items is already allocated to the group, if so, do not re-allocate.

Versions

2.x, 3.x

Issue Description

Discussion in PR #30

Possible Solution

Remove OR condition in DB query. Handle case where anonymousAccessToken is sent hashed and not hashed.

In the transformAndValidateCart mutation the cart schema is loaded directly from file as import { Cart as CartSchema } from "../simpleSchemas.js";. It makes it impossible to extend the cart schema as the validation fails. The schema should be retrieved from the context as follows: const CartSchema = context.simpleSchemas.Cart;

Carts uses the Address type in GraphQL, which lives in the accounts plugin.

When work is done to move carts over here, we need to be sure to install api-plugin-accounts as a peerDependency.

https://app.circleci.com/pipelines/github/reactioncommerce/reaction/4737/workflows/f3df07a3-61f7-4ea2-bf95-bab57e910596/jobs/69113

Issue Description

When querying for the images of a cart item, a null value is returned even for items that have images defined.

• Are you running the latest version?
• Are you able to consistently reproduce the issue?
• Did you search the issue queue for existing issue?

Steps to Reproduce

Running the following query for a cart that has an item with images:

query anonymousCartByCartIdQuery(
  $cartId: ID!
  $cartToken: String!
  $itemsAfterCursor: ConnectionCursor
) {
  cart: anonymousCartByCartId(cartId: $cartId, cartToken: $cartToken) {
    items(first: 20, after: $itemsAfterCursor) {
      nodes {
        imageURLs {
          large
          small
          original
          medium
          thumbnail
        }
      }
    }
  }
}

Returns:

{
  "data": {
    "cart": {
      "items": {
        "nodes": [
          {
            "imageURLs": null
          }
        ]
      }
    }
  }
}

Possible Solution

Looking into the code looks like nowhere in the resolvers the imageURLs property is set.
A possible solution is to query the needed media in the CartItem resolver, similar to how it's done in the products plugin.

Versions

4.0.0

This plugin uses the Address, and AddressInput types in GraphQL, which live in the address-validation plugin.

When work is done to move this plugin, we need to be sure to install api-plugin-address-validation as a peerDependency.

Carts uses the TagSortByField and TagConnection type in GraphQL, which lives in the tags plugin.

When work is done to move carts over here, we need to be sure to install api-plugin-tags as a peerDependency.

If we take the example of a product with two variants color and size, therefore to add product in cart we must select a color in variant colors and a size in variant sizes.

With the structure of the cart we won't be able to do this kind of manipulation.

My Solution

{
  "Cart" : {
     ...
     products: ["productId":....,
"shopId":.....,
"addedAt":....,
"position": ....,
"quantity":.....,
         "items": []
     ]
  }
}

is to group the selection items of each catalog product.

Prerequisites

• Are you running the latest version?
• Are you able to consistently reproduce the issue?
• Did you search the issue queue for existing issue? Search issues

Issue Description

When I query the cart for the productConfiguration field, I get this error:

"message": "Cannot return null for non-nullable field CartItem.productConfiguration.",
      "locations": [
        {
          "line": 34,
          "column": 11
        }
      ],
      "path": [
        "anonymousCartByCartId",
        "checkout",
        "fulfillmentGroups",
        0,
        "items",
        0,
        "productConfiguration"
      ],

When checking the plugin, productConfiguration is based on item.productId and item.variantId. Both exist in the database on the CartItem object.

Steps to Reproduce

1. Run the query anonymousCartByCartIdQuery in the playground for an anonymous cart.

Possible Solution

Could be that the fields are not included in the item object when it's getting the data from the mongo collection.

Versions

3.7.1