GithubHelp home page GithubHelp logo

Comments (4)

danielweck avatar danielweck commented on July 3, 2024

Please remember to check the "old" discussion thread (which wasn't imported here when the issue was moved):
readium/readium-js-viewer#51

from readium-shared-js.

danielweck avatar danielweck commented on July 3, 2024

Devs, see updatePagination() in reflowable_view.js
var columnizedContentWidth = _$epubHtml[0].scrollWidth
==> does not return the correct value in this particular case. However, these are correct:
$("body", _$epubHtml)[0].offsetWidth
$("body", _$epubHtml)[0].getBoundingClientRect().width
...unfortunately, even with overflow-x:visible, the CSS "right" offset (x axis) is not set correctly when switching pages.

This bug affects all WebKit-based web browser and WebViews, except Safari (at the moment).

from readium-shared-js.

danielweck avatar danielweck commented on July 3, 2024

Update: I have implemented a workaround which seems to work great. Testing now... (not just Japanese vertical writing, also Arabic Right To Left)

from readium-shared-js.

danielweck avatar danielweck commented on July 3, 2024

Fixed:
763d5b4

Could you please test the develop branch with Japanese ebooks that use vertical writing mode + Right To Left page progression direction (and optionally, HTML dir="rtl").

I personally tested several of those, one Arabic ebook, and several "regular" LTR reflowable ebooks with single-page and double-page (synthetic-spread).

Known caveat: deep linking into vertical-RTL documents is likely to fail, due to our existing "rectangle visibility" algorithm only suiting horizontal layout.

from readium-shared-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.