Comments (6)
See candidate fix in feature branch:
https://github.com/readium/readium-shared-js/tree/feature/scroll_img_resize
UPDATE: feature branch now deleted, but commit preserved as reference (proposal: scroll view acts like regular scrolling webpage => no arbitrary resize-to-fit imposed by reading system, just application of authored CSS styles).
Code diff:
30c0ecd
I do not think that this is a fully-satisfactory solution though, as many books I tried have image width/height either set via CSS or attributes, and the application of maximum values irrespective of aspect ratio sometimes produces unexpected / undesirable results. Furthermore, some images do not resize when opening the page for the first time, only when resizing the viewport.
In fairness though, the same problem already exists with the columnized paginated view:
https://github.com/readium/readium-shared-js/blob/develop/js/views/reflowable_view.js#L669
...so one could argue that the behaviour should be consistent across all types of reflowable views, and that we should apply the same image resizing algorithm to the scroll view?
from readium-shared-js.
See also: #45
from readium-shared-js.
See also:
#88
from readium-shared-js.
Shared utility function between scroll and column-paginated views:
Feature branch:
https://github.com/readium/readium-shared-js/tree/feature/scroll_img_resize
UPDATE: feature branch now deleted, but commit preserved as reference (proposal: scroll view acts like regular scrolling webpage => no arbitrary resize-to-fit imposed by reading system, just application of authored CSS styles).
from readium-shared-js.
I created a test file and verified this bug in the current build of the Chrome Extension. The file is here:
https://readiumfoundation.box.com/s/c9rxcdaszp39dswiw7su
from readium-shared-js.
We'll need to add this for svg's as well in your feature branch. It's just a matter of adding 'svg' to the jquery selector we use.
from readium-shared-js.
Related Issues (20)
- Chapters getting truncated [iOS - readium-shared-js library] HOT 4
- Absolutely positioned elements are misplaced HOT 5
- Building URL query parameters strips out #fragments HOT 1
- FAQ: custom external font faces
- Hyperlinking: hash fragment identifiers are discarded by internal pagination / scroll offset logic? HOT 3
- Use of reserved word "package" HOT 2
- Turn pages very slow in big html files with Android System Webview 63 HOT 25
- calculatePageIndexDeltaByRectangles has wrong logic calculating pageIndex HOT 6
- Build output: UMD bundle HOT 4
- Internet Explorer very slow to resize document with large spines (100+ pages)
- Please help, openContentUrl() dosen't work well in Electron app when the url contains #. HOT 1
- Rangy dependency not needed strictly-speaking (SMIL experimental feature + Juan's highlighter) HOT 2
- Firefox: Resize Sensor does not trigger when content after expanded element flows into following columns in a certain way
- Highlights HOT 1
- In Redium Reader CFI - is it possible to go exact CFI location in a reflowable document when search text location are multiple in a page HOT 4
- Is there any reason why navigator.epubReadingSystem is writable? HOT 2
- Invalid location/CFI received HOT 2
- Issue with continuous scrolling using (macOs + Safari) trackpad
- The page turn is not done with the readaloud
- API Document
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from readium-shared-js.