replit / crosis Goto Github PK

Uh, this doesn't really matter, and I'm sorry that I'm bothering you, but I just wanted to let you know that the description should be replit, not repl.it.

Thanks and sorry!

It's probably really easy to implement integration tests.

Right now when you send a request and the channel closes; whether it is due to client closing or calling channel.close we throw an error for that promise. I think it would be cleaner if we just returned something instead.

Which means if you want to handle that instance you need to put channe.request in a try catch, catch the error

This is common in our codebase, it's ugly and tedious!

let res
try {
  res = channel.request({ ... })
} catch (e) {
  if (/* assert if error is channel closed */) {
    handleChannelClosed();
    return;
  }

  throw e;
}

Not sure if this makes sense but I'm thinking this is better than throwing.

enum ChannelCloseReason {
  ClientClosed, // this means you called `Client::close`
  ClientDisconnect, // this means the websocket died unexpectedly
  ChannelClosed, // this means you called `Channel::close`
}

type RequestResult =
  | api.Command
  | { channelClosed: ChannelCloseReason; closeStatus: null }
  | { channelClosed: ChannelCloseReason.ChannelClosed; closeStatus: api.CloseChannelRes.Status };

interface Channel {
  request(cmd: api.Command): Promise<RequestResult>;
}

The JavaScript version can be published as a standalone package into NPM. This library can list it as a peer dependency (with minimum version).

The separate repo can also have bindings to different languages and publishes them to their respective package managers. Right now we use JavaScript and Go

Clearing the console with Ctrl+L keybinding twice results in a plugin crash with the following error message, probable front-end bug.

Error: TypeError: Cannot read property 'copyCellsFrom' of undefined