rl-vig / libcontinual Goto Github PK

Hi there,

I'm new to the field of continual learning and have been exploring various toolkits to deepen my understanding. Recently, I came across your LibContinual repository and noticed many similarities with another toolkit I'm familiar with, PyCIL (https://github.com/G-U-N/PyCIL).

While going through both repositories, I couldn't help but notice that significant portions of the code in LibContinual appear to be very similar, if not identical, to those in PyCIL. Below are some examples with screenshots for reference:

(Left: PyCIL, Right: LibContinual)

https://github.com/G-U-N/PyCIL/blob/a9b1ec8e3dbbe143cb72b008d7c8f946629d55b1/utils/inc_net.py#L138

(Left: PyCIL, Right: LibContinual)

https://github.com/G-U-N/PyCIL/blob/a9b1ec8e3dbbe143cb72b008d7c8f946629d55b1/models/ewc.py#L210

(It seems the indentation is directly copied from PyCIL LOL)

(Left: PyCIL, Right: LibContinual)

It seems like renaming the functions into a similar one...

These similarities raise some important questions:

Is it necessary to reinvent the wheel by creating a new repository that largely replicates the functionality and code of PyCIL?
Shouldn't there be proper acknowledgment and attribution to PyCIL, considering the significant overlap in code? This includes but is not limited to:

1. Including PyCIL's original MIT License.
2. Including commit history from PyCIL.
3. Featuring the original authors of PyCIL in the License and Contributor sections.
4. Respect for the original authors and adherence to open-source principles are vital for the community. Proper attribution not only honors the work done by the PyCIL authors but also fosters a collaborative and respectful open-source environment.

Looking forward to your thoughts on this matter.